[PATCH v1 32/44] dmaengine: sdxi: amd: execute QoS vendor operations

From: Wei Huang

Date: Thu Nov 19 2026 - 15:31:47 EST


Add execution code for AMD QoS capability, device update, pool update,
function update and telemetry operations.

Signed-off-by: Wei Huang <wei.huang2@xxxxxxx>
---
drivers/dma/sdxi/amd/qos.c | 321 ++++++++++++++++++++++++++++++++++++-
1 file changed, 320 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/sdxi/amd/qos.c b/drivers/dma/sdxi/amd/qos.c
index 746e4c8b11e7..7d5dc9b6b32c 100644
--- a/drivers/dma/sdxi/amd/qos.c
+++ b/drivers/dma/sdxi/amd/qos.c
@@ -27,7 +27,13 @@
#define SDXI_AMD_QOS_TEL_FIXED_BYTES 48U
#define SDXI_AMD_QOS_TEL_HDR_BYTES 48U
#define SDXI_AMD_QOS_POOL_REPORT_ENTRY_BYTES 132U
-#define SDXI_AMD_QOS_MAX_TEL_BYTES SZ_1M
+
+/* One PF entry plus all 10-bit VF-number entries. */
+#define SDXI_AMD_QOS_POOL_REPORT_MAX_FUNCTIONS 1025U
+#define SDXI_AMD_QOS_POOL_REPORT_MAX_BYTES \
+ (SDXI_AMD_QOS_TEL_HDR_BYTES + \
+ SDXI_AMD_QOS_POOL_REPORT_MAX_FUNCTIONS * \
+ SDXI_AMD_QOS_POOL_REPORT_ENTRY_BYTES)

struct sdxi_amd_qos_cap_info {
u16 feature_flags;
@@ -764,3 +770,316 @@ static int sdxi_amd_qos_prevalidate_tel(struct sdxi_dev *sdxi,
return 0;
}
}
+
+static size_t sdxi_amd_qos_tel_bytes_active_pools(u16 max_pools)
+{
+ return SDXI_AMD_QOS_TEL_HDR_BYTES + (size_t)(max_pools + 7U) / 8U;
+}
+
+static int sdxi_amd_qos_pool_report_bytes(u16 assigned_functions,
+ size_t *bytes)
+{
+ if (assigned_functions > SDXI_AMD_QOS_POOL_REPORT_MAX_FUNCTIONS)
+ return -E2BIG;
+
+ *bytes = SDXI_AMD_QOS_TEL_HDR_BYTES +
+ (size_t)assigned_functions *
+ SDXI_AMD_QOS_POOL_REPORT_ENTRY_BYTES;
+ return 0;
+}
+
+static int sdxi_amd_qos_exec(struct sdxi_dev *sdxi, u16 opcode_type,
+ struct sdxi_admin_vendor_args *args,
+ unsigned int timeout_ms)
+{
+ struct sdxi_cxt *adm = sdxi->admin_cxt;
+ struct sdxi_amd_qos_cap_info cap;
+ struct sdxi_desc desc;
+ void *buf = NULL;
+ dma_addr_t buf_dma = 0;
+ size_t dma_size = 0;
+ size_t required = 0;
+ void __user *ubuf = NULL;
+ u32 output_available = args->out_size;
+ bool pool_report = false;
+ int err;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ switch (args->op) {
+ case SDXI_AMD_QOS_ADMIN_OP_CAP:
+ err = sdxi_amd_qos_copy_input(args, NULL, 0);
+ if (err)
+ return err;
+
+ required = SDXI_AMD_QOS_CAP_BYTES;
+ err = sdxi_amd_qos_prepare_output(args, required, &ubuf);
+ if (err)
+ return err;
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_CAP);
+ break;
+ case SDXI_AMD_QOS_ADMIN_OP_DEVUPD: {
+ struct sdxi_amd_qos_devupd_req req;
+ struct sdxi_amd_qos_dev_info info;
+
+ err = sdxi_amd_qos_copy_input(args, &req, sizeof(req));
+ if (err)
+ return err;
+ err = sdxi_amd_qos_get_cap_info(sdxi, adm, opcode_type,
+ timeout_ms, &cap);
+ if (err)
+ return err;
+ err = sdxi_amd_qos_get_dev_info(sdxi, adm, opcode_type,
+ timeout_ms, &info);
+ if (err)
+ return err;
+ err = sdxi_amd_qos_validate_devupd_req(req.device_maxbw,
+ cap.device_maxbw_cap,
+ info.total_allocated_bw,
+ cap.granularity_bw);
+ if (err)
+ return err;
+
+ err = sdxi_amd_qos_require_no_output(args);
+ if (err)
+ return err;
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_DEVUPD);
+ put_unaligned_le32(req.device_maxbw, &desc.generic.operation[4]);
+
+ return sdxi_adm_submit_desc(adm, &desc, timeout_ms,
+ &args->cst_flags);
+ }
+ case SDXI_AMD_QOS_ADMIN_OP_POOLUPD: {
+ struct sdxi_amd_qos_poolupd_req req;
+ u32 pool_ctl;
+
+ err = sdxi_amd_qos_copy_input(args, &req, sizeof(req));
+ if (err)
+ return err;
+ err = sdxi_amd_qos_get_cap_info(sdxi, adm, opcode_type,
+ timeout_ms, &cap);
+ if (err)
+ return err;
+ err = sdxi_amd_qos_prevalidate_poolupd(sdxi, adm, opcode_type,
+ timeout_ms, &cap, &req);
+ if (err)
+ return err;
+
+ err = sdxi_amd_qos_require_no_output(args);
+ if (err)
+ return err;
+
+ pool_ctl = FIELD_PREP(GENMASK(11, 0), req.pool_num) |
+ FIELD_PREP(GENMASK(13, 12), req.pool_operation);
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_POOLUPD);
+ put_unaligned_le32(pool_ctl, &desc.generic.operation[0]);
+ put_unaligned_le32(req.pool_maxbw, &desc.generic.operation[4]);
+ put_unaligned_le32(req.pool_minbw, &desc.generic.operation[8]);
+
+ return sdxi_adm_submit_desc(adm, &desc, timeout_ms,
+ &args->cst_flags);
+ }
+ case SDXI_AMD_QOS_ADMIN_OP_FNUPD: {
+ struct sdxi_amd_qos_fnupd_req req;
+ u32 target_scope;
+ u32 cxt_range;
+
+ err = sdxi_amd_qos_copy_input(args, &req, sizeof(req));
+ if (err)
+ return err;
+ err = sdxi_amd_qos_get_cap_info(sdxi, adm, opcode_type,
+ timeout_ms, &cap);
+ if (err)
+ return err;
+ err = sdxi_amd_qos_prevalidate_fnupd(sdxi, adm, opcode_type,
+ timeout_ms, &cap, &req);
+ if (err)
+ return err;
+
+ err = sdxi_amd_qos_target_scope(req.pool_num, req.flags,
+ req.vf_num, &target_scope);
+ if (err)
+ return err;
+
+ err = sdxi_amd_qos_require_no_output(args);
+ if (err)
+ return err;
+
+ cxt_range = FIELD_PREP(GENMASK(15, 0), req.cxt_start) |
+ ((u32)req.cxt_end << 16);
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_FNUPD);
+ put_unaligned_le32(target_scope, &desc.generic.operation[0]);
+ put_unaligned_le32(cxt_range, &desc.generic.operation[4]);
+
+ return sdxi_adm_submit_desc(adm, &desc, timeout_ms,
+ &args->cst_flags);
+ }
+ case SDXI_AMD_QOS_ADMIN_OP_TEL: {
+ struct sdxi_amd_qos_tel_req req;
+ u32 target_scope;
+ u64 query_selector;
+ u16 assigned_functions;
+
+ err = sdxi_amd_qos_copy_input(args, &req, sizeof(req));
+ if (err)
+ return err;
+ err = sdxi_amd_qos_get_cap_info(sdxi, adm, opcode_type,
+ timeout_ms, &cap);
+ if (err)
+ return err;
+ err = sdxi_amd_qos_prevalidate_tel(sdxi, adm, opcode_type,
+ timeout_ms, &cap, &req);
+ if (err)
+ return err;
+
+ switch (req.query_type) {
+ case SDXI_AMD_QOS_TEL_QTYPE_DEVICE:
+ target_scope = 0;
+ query_selector = sdxi_amd_qos_query_selector(0,
+ req.query_type);
+ required = SDXI_AMD_QOS_TEL_FIXED_BYTES;
+ break;
+ case SDXI_AMD_QOS_TEL_QTYPE_POOL_CONFIG:
+ target_scope = FIELD_PREP(GENMASK(11, 0),
+ req.pool_num);
+ query_selector = sdxi_amd_qos_query_selector(0,
+ req.query_type);
+ required = SDXI_AMD_QOS_TEL_FIXED_BYTES;
+ break;
+ case SDXI_AMD_QOS_TEL_QTYPE_POOL_ASSIGN:
+ err = sdxi_amd_qos_target_scope(0, req.flags,
+ req.vf_num,
+ &target_scope);
+ if (err)
+ return err;
+ if (!(req.flags & SDXI_AMD_QOS_TARGET_F_CXT))
+ req.cxt_num = 0;
+ query_selector = sdxi_amd_qos_query_selector(req.cxt_num,
+ req.query_type);
+ required = SDXI_AMD_QOS_TEL_FIXED_BYTES;
+ break;
+ case SDXI_AMD_QOS_TEL_QTYPE_ACTIVE_POOLS:
+ target_scope = 0;
+ query_selector = sdxi_amd_qos_query_selector(0,
+ req.query_type);
+ required =
+ sdxi_amd_qos_tel_bytes_active_pools(cap.max_pools);
+ break;
+ case SDXI_AMD_QOS_TEL_QTYPE_POOL_REPORT:
+ target_scope = FIELD_PREP(GENMASK(11, 0),
+ req.pool_num);
+ query_selector = sdxi_amd_qos_query_selector(0,
+ req.query_type);
+ err = sdxi_amd_qos_get_assigned_functions(sdxi, adm,
+ opcode_type,
+ req.pool_num,
+ timeout_ms,
+ &assigned_functions);
+ if (err)
+ return err;
+
+ err = sdxi_amd_qos_pool_report_bytes(assigned_functions,
+ &required);
+ if (err)
+ return err;
+ dma_size = SDXI_AMD_QOS_POOL_REPORT_MAX_BYTES;
+ pool_report = true;
+ break;
+ case SDXI_AMD_QOS_TEL_QTYPE_POOL_VARIANCE:
+ target_scope = FIELD_PREP(GENMASK(11, 0),
+ req.pool_num);
+ query_selector = sdxi_amd_qos_query_selector(0,
+ req.query_type);
+ required = SDXI_AMD_QOS_TEL_FIXED_BYTES;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ err = sdxi_amd_qos_prepare_output(args, required, &ubuf);
+ if (err)
+ return err;
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_TEL);
+ put_unaligned_le32(target_scope, &desc.generic.operation[0]);
+ put_unaligned_le64(query_selector, &desc.generic.operation[4]);
+ break;
+ }
+ default:
+ return -EOPNOTSUPP;
+ }
+
+ if (!dma_size)
+ dma_size = required;
+
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), dma_size, &buf_dma,
+ GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, dma_size);
+
+ if (!IS_ALIGNED(buf_dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free_submit;
+ }
+
+ switch (args->op) {
+ case SDXI_AMD_QOS_ADMIN_OP_CAP:
+ put_unaligned_le64(buf_dma, &desc.generic.operation[4]);
+ break;
+ case SDXI_AMD_QOS_ADMIN_OP_TEL:
+ put_unaligned_le64(buf_dma, &desc.generic.operation[12]);
+ break;
+ default:
+ err = -EINVAL;
+ goto out_free_submit;
+ }
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, &args->cst_flags);
+ if (err)
+ goto out_free_submit;
+
+ dma_rmb();
+ if (pool_report) {
+ size_t actual_required;
+ u32 data_length = get_unaligned_le32(buf + 20);
+ u16 assigned_functions = get_unaligned_le16(buf + 16);
+
+ err = sdxi_amd_qos_pool_report_bytes(assigned_functions,
+ &actual_required);
+ if (err || data_length !=
+ actual_required - SDXI_AMD_QOS_TEL_HDR_BYTES) {
+ err = -EIO;
+ goto out_free_submit;
+ }
+
+ args->out_size = actual_required;
+ if (output_available < actual_required) {
+ err = -ENOSPC;
+ goto out_free_submit;
+ }
+ if (!access_ok(ubuf, actual_required)) {
+ err = -EFAULT;
+ goto out_free_submit;
+ }
+ required = actual_required;
+ }
+ if (copy_to_user(ubuf, buf, required))
+ err = -EFAULT;
+
+out_free_submit:
+ dma_free_coherent(sdxi_to_dev(sdxi), dma_size, buf, buf_dma);
+ return err;
+}
--
2.56.1