Re: [PATCH v4] HID: wacom: validate battery range before scaling
From: Jiri Kosina
Date: Thu Nov 19 2026 - 15:37:40 EST
On Mon, 9 Nov 2026, Jason Gerecke wrote:
> On Fri, Nov 6, 2026 at 5:26 PM Aldo Ariel Panzardo <qwe.aldo@xxxxxxxxx> wrote:
> >
> > Battery events divide by the difference between the logical maximum
> > and minimum without validating the range. A malformed HID descriptor
> > with equal limits can therefore trigger a divide-by-zero exception.
> >
> > Move percentage conversion to a helper that rejects non-positive
> > ranges and accounts for a nonzero logical minimum. Clamp the result
> > to [0, 100] as an additional safeguard against out-of-range
> > percentages.
> >
> > Fixes: 37d160193834 ("HID: wacom: generic: Scale battery capacity measurements to percentages")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Aldo Ariel Panzardo <qwe.aldo@xxxxxxxxx>
>
> LGTM
>
> Reviewed-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
Applied to hid.git#for-7.4/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs