[PATCH v2 4/6] pinctrl: mediatek: Guard against NULL eint in mtk_eint_do_suspend() and mtk_eint_do_resume()

From: Lee Jones

Date: Thu Nov 19 2026 - 15:48:33 EST


mtk_paris_pinctrl_probe() treats mtk_build_eint() failure as non-fatal,
logging a warning and completing probe with hw->eint left as NULL
whenever EINT initialisation is skipped or fails. However, the system
sleep callbacks pass pctl->eint unconditionally to
mtk_eint_do_suspend() and mtk_eint_do_resume(), both of which
dereference eint without checking for NULL.

Return 0 early from mtk_eint_do_suspend() and mtk_eint_do_resume() when
eint is NULL.

Fixes: 5c0904488a20 ("pinctrl: mediatek: Add pm_ops to pinctrl-paris")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
---

v1 => v2:
- New patch, avoiding a NULL dereference on suspend/resume when EINT
setup fails (Sashiko)

drivers/pinctrl/mediatek/mtk-eint.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/pinctrl/mediatek/mtk-eint.c b/drivers/pinctrl/mediatek/mtk-eint.c
index 827231dc0d24..ca47a416c666 100644
--- a/drivers/pinctrl/mediatek/mtk-eint.c
+++ b/drivers/pinctrl/mediatek/mtk-eint.c
@@ -427,6 +427,9 @@ static void mtk_eint_irq_handler(struct irq_desc *desc)

int mtk_eint_do_suspend(struct mtk_eint *eint)
{
+ if (!eint)
+ return 0;
+
mtk_eint_chip_write_mask(eint, eint->wake_mask);

return 0;
@@ -435,6 +438,9 @@ EXPORT_SYMBOL_GPL(mtk_eint_do_suspend);

int mtk_eint_do_resume(struct mtk_eint *eint)
{
+ if (!eint)
+ return 0;
+
mtk_eint_chip_write_mask(eint, eint->cur_mask);

return 0;
--
2.56.1.750.gf70dc682cf-goog