Re: [PATCH net] ieee802154: keep the original error after a netns rollback

From: Miquel Raynal

Date: Thu Nov 19 2026 - 15:53:17 EST


Hello Andrey,

> +++ b/net/ieee802154/core.c
> @@ -222,6 +222,7 @@
> {
> struct wpan_dev *wpan_dev;
> int err = 0;
> + int ret;
>
> list_for_each_entry(wpan_dev, &rdev->wpan_dev_list, list) {
> if (!wpan_dev->netdev)
> @@ -249,6 +250,7 @@
> return 0;
>
> errout:
> + ret = err;
> /* failed -- clean up to old netns */
> net = wpan_phy_net(&rdev->wpan_phy);
>
> @@ -264,7 +266,7 @@
> wpan_dev->netdev->netns_immutable = true;

Shall we just shadow int err in this loop? the current implementation is
correct but is a bit strange (having ret and err next to each other).

> }
>
> - return err;
> + return ret;
> }
>
> void cfg802154_dev_free(struct cfg802154_registered_device *rdev)

Thanks,
Miquèl