Re: [PATCH] HID: core: serialize report_descriptor_read() against probe and remove

From: Jiri Kosina

Date: Thu Nov 19 2026 - 15:56:00 EST


On Sat, 10 Oct 2026, Krish Gulati wrote:

> Since commit 54f32fd5dff9 ("HID: Make report_descriptor available for
> all devices"), the "report_descriptor" sysfs attribute is part of the
> device's attribute group, so it exists from device_add() until
> device_del(). It reads hdev->rdesc, but that buffer only lives from
> hid_open_report() until hid_close_report(), that is, for the duration
> of a driver binding. For a driver with a report_fixup() callback,
> rdesc is a private copy that hid_close_report() frees, so a read that
> races with the driver being unbound accesses freed memory. syzbot
> reports this as:
>
> BUG: KASAN: slab-use-after-free in report_descriptor_read+0xb5/0x100
> Read of size 24 at addr ffff888078d61f00 by task fido_id/7281
> ...
> Allocated by task 10:
> kmemdup_noprof+0x2b/0x70
> hid_open_report+0x1fa/0xf00
> lg_probe+0x29c/0x890
> hid_device_probe+0x46a/0x870
> ...
>
> Because hid_close_report() also clears rdesc and rsize, the same missing
> serialization can make the reader see a NULL rdesc with a non-zero
> rsize.
>
> Hold the device lock in report_descriptor_read(). The driver core
> already holds it across probe and remove, so a read can no longer
> overlap with them.
>
> Reported-by: syzbot+bc537ca7a0efe33988eb@xxxxxxxxxxxxxxxxxxxxxxxxx
> Tested-by: syzbot+bc537ca7a0efe33988eb@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=bc537ca7a0efe33988eb
> Fixes: 54f32fd5dff9 ("HID: Make report_descriptor available for all devices")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Krish Gulati <krishgulati7@xxxxxxxxx>

Applied, thanks.

--
Jiri Kosina
SUSE Labs