Re: [PATCH v3] tracepoint-update: check the section end before reading a string
From: Steven Rostedt
Date: Thu Nov 19 2026 - 16:03:00 EST
On Mon, 9 Nov 2026 18:01:17 -0600
Leizhen Zhang <lzsx618@xxxxxxxxx> wrote:
> diff --git a/scripts/tracepoint-update.c b/scripts/tracepoint-update.c
> index 5cf43c0aac89..c70c0b076554 100644
> --- a/scripts/tracepoint-update.c
> +++ b/scripts/tracepoint-update.c
> @@ -74,7 +74,7 @@ static int add_string(const char *str, const char ***vals, int *count)
> #define for_each_shdr_str(len, ehdr, sec) \
> for (const char *str = (void *)(ehdr) + shdr_offset(sec), \
> *end = str + shdr_size(sec); \
> - len = strlen(str), str < end; \
> + str < end && (len = strlen(str), true); \
The above is hard to read. What about:
(len = str < end ? strlen(str) : -1) >= 0
It sets len to strlen(str) when str < end and exits the loop when str >= end.
-- Steve
> str += (len) + 1)
>