Re: [PATCH net-next v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible

From: Rob Herring (Arm)

Date: Thu Nov 19 2026 - 16:03:47 EST



On Tue, 03 Nov 2026 20:03:19 -0800, muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
>
> The Agilex5 SoCDK TSN Config2 gmac1 path includes an FPGA soft-IP
> GMII-to-RGMII converter between the DWXGMAC and the PHY. The converter
> provides the RGMII TX/RX delays and presents GMII toward the MAC, unlike
> a plain altr,socfpga-stmmac-agilex5 port with no such converter.
>
> Add altr,socfpga-stmmac-agilex5-tsn for that integration in the same
> compatible items entry as altr,socfpga-stmmac-agilex5 (shared
> snps,dwxgmac-2.10). Do not use altr,socfpga-stmmac-agilex5 as a DT
> fallback for the TSN port; the converter presents GMII to the MAC and
> supplies the RGMII delays, unlike a plain Agilex5 GMAC port.
>
> The TSN port uses the same DWXGMAC-2.10 core as the plain Agilex5 port,
> so extend the interrupt/interrupt-names/dma-coherent conditional to
> match the new compatible as well; otherwise a TSN node would incorrectly
> fall into the single-interrupt, non-coherent else branch.
>
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
> ---
> Previously patch 3 of the v6 board series; split out for net-next.
>
> v2: Extend the interrupt/interrupt-names/dma-coherent allOf conditional to
> match altr,socfpga-stmmac-agilex5-tsn, per Jakub Kicinski / netdev bot.
> v6: Put altr,socfpga-stmmac-agilex5-tsn in the same enum as
> altr,socfpga-stmmac-agilex5, per Krzysztof Kozlowski.
> v5: Drop altr,socfpga-stmmac-agilex5 fallback and rewrite commit message
> to explain hardware incompatibility, per Krzysztof Kozlowski.
>
> .../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>