Re: [PATCH v1 1/1] bitmap: Refactor bitmap_read() and bitmap_write() to avoid too big shift

From: Yury Norov

Date: Thu Nov 19 2026 - 16:24:20 EST


On Thu, Nov 19, 2026 at 11:03:53PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 19, 2026 at 03:37:33PM -0500, Yury Norov wrote:
> > On Thu, Nov 19, 2026 at 08:15:30PM +0100, Andy Shevchenko wrote:
>
> Thanks for review, my answers below.
>
> > > While compiling ad4691.c I have noticed the following warnings:
> > >
> > > drivers/iio/adc/ad4691.c: note: in included file:
> > > include/linux/bitmap.h:854:55: warning: shift too big (64) for type unsigned long
> > > include/linux/bitmap.h:854:55: warning: shift too big (64) for type unsigned long
> > >
> > > Since the bitmap_read() is called with statically define 'start',
> > > the 'space' local variable becomes equal to BITS_PER_LONG, or 64 on
> > > 64-bit machines. The 'nbits' parameter is coming from the run-time
> > > defined value. Static analyser doesn't see that the right shift
> > > by 64-bit can't happen — the space >= nbits check guards that.
> > > While Jonathan put it as false positive [1], we still can give a hint
> > > to it without growing in the code (`bloat-o-meter` for above mentioned
> > > driver shows no difference in size). So this is what this change does.
> >
> > Jonathan put it right.
> >
> > If the analyzer (assuming sparse?) throws false positives, we don't
> > need to change the kernel. This is simply a wrong motivation. We need
> > to improve sparse instead.
> >
> > Otherwise, the kernel will become a collection of hacks for various
> > poorly written tools. Let's do it the other way, please.
>
> I agree in general. However, we can sometimes give hints without breaking the code.
> Now, thinking of this, the mentioned check can be done against offset leaving code
> generation and sparse happy and have no unneeded bulk.
>
> > > For completeness, bitmap_write() is also refactored in the similar manner.
> > > I have also checked a few users of it and `bloat-o-meter` showed no change.
>
> ...
>
> > > - if (space >= nbits)
> > > + if (space >= nbits || offset == 0)
> > > return (map[index] >> offset) & BITMAP_LAST_WORD_MASK(nbits);
> >
> > So, doubling the number of conditions, and the new one duplicates the
> > existing check. This version suppresses sparse false positive:
> >
> > if (offset <= BITS_PER_LONG - nbits)
>
> Yes, you beat me up to it. I just was thinking about similar check in the above
> comment.
>
> > And even with that I'm not sure we need to touch the kernel to make
> > sparse or whatever else tool happy...
>
> It might take ages for sparse to fix even more annoying issues (if you remember
> something related to cleanup or alike change in the kernel and sparse was
> lagging for weeks).
>
> ...
>
> > > size_t index;
> > > - unsigned long offset;
> > > - unsigned long space;
> > > - unsigned long mask;
> > > - bool fit;
> > > + unsigned long offset = start % BITS_PER_LONG;
> > > + unsigned long space = BITS_PER_LONG - offset;
> > >
> > > if (unlikely(!nbits || nbits > BITS_PER_LONG))
> > > return;
> >
> > Initialization of local variables before the sanity check
> > may become useless waste of cycles if this sanity fails.
>
> How? they are not used and function is marked as always inline. I believe
> optimisation in the compiler does the right thing.

Maybe yes. I've seen quite many non-trivial compiler decisions before,
so I want to make sure...

> > This is also not necessarily needed for sparse happiness,
>
> This is to make both look similar at a glance.
>
> > I guess... Let's keep the patch minimal?
> >
> > > - mask = BITMAP_LAST_WORD_MASK(nbits);
> > > - value &= mask;
> > > - offset = start % BITS_PER_LONG;
> > > - space = BITS_PER_LONG - offset;
> > > - fit = space >= nbits;
> >
> > I don't like this 'fit' thing, and would like to drop it. But
> > let's find a better motivation to do that?
>
> Why? The fit keeps the check I want to refactor, since it makes it twice
> the code with that ternary looks ugly and unreadable. This is exactly the
> chance to kill two birds with one stone.

That's what I meant regarding the motivational part and minimizing the
patch.

Thanks,
Yury