Re: [PATCH v2] erofs: set SB_I_ALLOW_HSM for bdev-based mounts

From: Gao Xiang

Date: Thu Nov 19 2026 - 16:40:37 EST


Hi Friendy,

On Fri, Oct 23, 2026 at 10:16:35AM +0800, Friendy Su wrote:
> SB_I_ALLOW_HSM makes erofs support fanotify FAN_PRE_ACCESS event
> for bdev-based mounts. file-backed mounts do not support this.
>
> This is for use case that erofs file data is not available on
> local block device at mount, but need to be filled at fanotify
> FAN_PRE_ACCESS event handler.
>
> E.g. format erofs to blob mode, meta data on /dev/pmem0, file data
> on blob device /dev/pmem1. The file content in blob device is dummy.
>
> mount as below:
>
> $ sudo mount -o dax,device=/dev/pmem1 /dev/pmem0 /mnt/erofs/
>
> In FAN_PRE_ACCESS handler, actual file content is fetched from remote
> then filled into the DAX mounted block device /dev/pmem1.


Set SB_I_ALLOW_HSM to enable fanotify FAN_PRE_ACCESS events for
bdev-backed mounts. File-backed mounts are not supported.

This allows EROFS to handle cases where file data is not available
locally at mount time and needs to be fetched on demand by a
FAN_PRE_ACCESS event handler.

For example, an EROFS image can use blob mode with metadata stored
on /dev/pmem0 and file data on /dev/pmem1, where the latter initially
contains dummy data.

The filesystem can be mounted with:

mount -o dax,device=/dev/pmem1 /dev/pmem0 /mnt/erofs

On receiving a FAN_PRE_ACCESS event, the handler fetches the actual
file data from a remote source and fills the corresponding blocks
on /dev/pmem1 before access proceeds.


>
> Signed-off-by: Friendy Su <friendy.su@xxxxxxxx>
> Reviewed-by: Yuezhang Mo <Yuezhang.Mo@xxxxxxxx>
> Reviewed-by: Daniel Palmer <daniel.palmer@xxxxxxxx>
> ---
> fs/erofs/super.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 0967aace9f7f..be8728b8d116 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -667,6 +667,15 @@ static int erofs_fc_fill_super(struct super_block *sb, struct fs_context *fc)
> errorfc(fc, "FSDAX is not allowed when inode_share is on");
> return -EINVAL;
> }
> + if (!erofs_is_fileio_mode(sbi)) {
> + /*
> + * Only enable HSM to support fanotify FAN_PRE_ACCESS event
> + * under block device backed mounts.
> + * For file-backed mounts, do not enable since erofs-utils
> + * has already supported FAN_PRE_ACCESS event on backend image.
> + */

Could you just change it to

* Follow other filesystems by supporting FAN_PRE_ACCESS events
* only on bdev-backed mount. Don't bother with file-backed mounts.

I hope we could avoid mentioning user-space details
in the kernel codebase directly.

Could you send a new version as I suggested, otherwise
it looks good to me,

Reviewed-by: Gao Xiang <xiang@xxxxxxxxxx>

Thanks,
Gao Xiang

> + sb->s_iflags |= SB_I_ALLOW_HSM;
> + }
>
> sbi->blkszbits = PAGE_SHIFT;
> if (erofs_is_fileio_mode(sbi)) {
> --
> 2.34.1
>
>