Re: [PATCH] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()

From: Andi Shyti

Date: Thu Nov 19 2026 - 17:05:03 EST


Hi Joonas,

On Thu, Nov 19, 2026 at 10:04:06AM +0200, Joonas Lahtinen wrote:
> Quoting Haoxiang Li (2026-11-18 17:32:05)
> > i915_vma_pin_ww() allocates bind work before retrieving the object's
> > moving fence. If the lookup fails, it jumps to err_rpm, bypassing the
> > fence commit at err_fence and leaking the work allocation.
> >
> > Jump to err_fence instead so the fence callbacks can release the work.
> >
> > Fixes: 8ec5c0006c50 ("Merge tag 'drm-intel-next-2022-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-gt-next")
> > Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
>
> You seem to be spamming the different kernel subsystems with patches and
> never respond to any feedback, so if you could just stop and do something
> else.

The patch is correct, though, and I'd take it.

If Haoxiang is not responding to other patches then bad for him
and I'd give the same suggestion as you did. But if we are not
taking this patch, then we would remain with a clear known
liability in our code.

Andi