Re: [PATCH v3 2/4] clk: siflower: Add SF19A2890 clock manager driver

From: Brian Masney

Date: Thu Nov 19 2026 - 18:16:57 EST


On Thu, Nov 19, 2026 at 04:31:01PM -0500, Joseph Telaak wrote:
> On Thu, Nov 19, 2026 at 02:00:06PM -0500, Brian Masney wrote:
> > Can this declared as a regular platform driver? We are trying to
> > minimize the use of CLK_OF_DECLARE.
>
> The MIPS GIC timer runs from CLK_MUXDIV_CPU, and it probes from
> TIMER_OF_DECLARE in time_init(), before any platform driver. As a
> platform driver, the clock would not exist yet when the timer calls
> of_clk_get(), and with no clock-frequency to fall back on, the SoC would
> have no clocksource. I'll say that in a comment above CLK_OF_DECLARE in
> v4.

If possible, declare just the timer clock with CLK_OF_DECLARE, and the
rest as a platform driver.

Brian