Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
From: Edgecombe, Rick P
Date: Thu Nov 19 2026 - 18:18:17 EST
On Tue, 2026-11-17 at 16:43 +0800, Haoxiang Li wrote:
> For x86 PV guests, arch_gnttab_init() allocates virtual address areas
> and PTE pointer arrays for the shared and status frames. These
> resources are not released if the subsequent gnttab_setup() call fails.
>
> Add arch_gnttab_free() and call it on this failure path before the
> existing cleanup. Provide an empty implementation for ARM, which
> is also used by ARM64.
>
> Fixes: 162e37171276 ("x86/xen: safely map and unmap grant frames when in atomic context")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
If the PV guest hits this scenario can it survive? I don't know xen pv very
well. Does this means that the PV guest has no disk or network. If so, the user
is probably not concerned with a one time memory leak.