Re: [PATCH net 1/2] udp: restore outer transport header after tunnel GRO
From: Jakub Kicinski
Date: Thu Nov 19 2026 - 18:21:00 EST
On Wed, 11 Nov 2026 22:07:07 -0500 Bryon Fryer wrote:
> @@ -948,6 +948,8 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff,
> skb->encapsulation = 1;
> err = udp_sk(sk)->gro_complete(sk, skb,
> nhoff + sizeof(struct udphdr));
> + if (!err)
> + skb_set_transport_header(skb, nhoff);
IIUC only UDP bothers us because that's what virtio/tun supports but
isn't the header stale for every tunnel (eg GRE?) Should we not reset
this back in inet_gro_complete()/ipv6_gro_complete() ?
Maybe GRO experts prefer it here, dunno. An ACK from someone who
understands this code better than me would be good.