[PATCH v2 6/6] KVM: Extract and dedup the kick code to check if a CPU needs an IPI

From: Sean Christopherson

Date: Thu Nov 19 2026 - 18:57:43 EST


Extract the kick logic's code to determine if a target CPU actually needs
an IPI into a helper function. In addition to deduplicating the existing
checks in common KVM, the helper can "likely" (read: will) be eventually
used in arch specific code as well.

No functional change intended: KVM always uses '-1' to indicate an invalid
vcpu->cpu, so "!= -1", "(unsigned int)cpu < nr_cpu_ids", and ">= 0" are all
functionally equivalent.

Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
---
virt/kvm/kvm_main.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 48fef91b8530..d8027ea0c447 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -209,6 +209,11 @@ static bool kvm_request_needs_ipi(struct kvm_vcpu *vcpu, unsigned req)
return mode == IN_GUEST_MODE;
}

+static bool kvm_cpu_needs_ipi(int cpu, int me)
+{
+ return cpu >= 0 && cpu != me && cpu_online(cpu);
+}
+
static void ack_kick(void *_completed)
{
}
@@ -273,7 +278,7 @@ static void kvm_make_vcpu_request(struct kvm_vcpu *vcpu,
*/
if (kvm_request_needs_ipi(vcpu, kick->req)) {
cpu = READ_ONCE(vcpu->cpu);
- if (cpu != -1 && cpu != kick->me && cpu_online(cpu)) {
+ if (kvm_cpu_needs_ipi(cpu, kick->me)) {
kick->need_kick = true;
if (kick->cpus)
__cpumask_set_cpu(cpu, kick->cpus);
@@ -3951,7 +3956,7 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait)
*/
if (kvm_arch_vcpu_should_kick(vcpu)) {
cpu = READ_ONCE(vcpu->cpu);
- if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) {
+ if (kvm_cpu_needs_ipi(cpu, me)) {
/*
* Use a reschedule IPI to kick the vCPU if the caller
* doesn't need to wait for a response, as KVM allows
--
2.56.1.708.g77570a6a1d-goog