[PATCH v9 05/14] drm/bridge: it6505: complete poweroff even if disabling regulators fails
From: Daniel Golle
Date: Thu Nov 19 2026 - 19:00:16 EST
it6505_poweroff() returns early when regulator_disable() fails,
leaving it6505->powered set with the IRQ already disabled. The next
it6505_poweron() then takes its early return and never re-enables the
IRQ, leaving the bridge deaf to hotplug and link training interrupts.
The regulator core keeps the consumer's enable count on a failed
disable either way, so bailing out only adds a wedged bridge on top of
the leaked reference. Log the error and complete the power-off state
transition instead.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> # Steelix Chromebook
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
---
drivers/gpu/drm/bridge/ite-it6505.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 42fd24de9e147..249c616300fde 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2816,13 +2816,15 @@ static int it6505_poweroff(struct it6505 *it6505)
if (pdata->pwr18) {
err = regulator_disable(pdata->pwr18);
if (err)
- return err;
+ dev_err(dev, "cannot disable pwr18 regulator: %d\n",
+ err);
}
if (pdata->ovdd) {
err = regulator_disable(pdata->ovdd);
if (err)
- return err;
+ dev_err(dev, "cannot disable ovdd regulator: %d\n",
+ err);
}
it6505->powered = false;
--
2.56.1