Re: [PATCH v13 1/5] dt-bindings: clock: airoha: Document support for AN7583 clock
From: Brian Masney
Date: Thu Nov 19 2026 - 19:03:03 EST
Hi Christian,
> Document support for Airoha AN7583 clock. This is based on the EN7523
> clock schema with the new requirement of the "airoha,chip-scu".
>
> The register for clock and reset for normal system and PCIe are scattered
> between the "SCU" and "chip SCU" registers (they are 2 different register
> block, the name is taken from the programming guide)
>
> - Chip SCU provide register access to some clk gate and clk rate
> - SCU provide register for reset, PCIe clock, other clock gate and PHY
> SERDES.
>
> Upcoming and current airoha clock driver all follow this pattern of
> declaring one of the 2 register and use a sysconf for the other as the 2
> register block are tighlty coupled.
>
> EN7581 internally handle the syscon with a direct reference by the use of
> syscon_regmap_lookup_by_compatible while AN7583 wants to make this
> explicit in DT with the new "airoha,chip-scu" phandle.
>
> Similar to EN7581, also AN7583 permit the selection of the serdes line.
>
> Add additional binding for additional clock and reset lines.
>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
> .../bindings/clock/airoha,en7523-scu.yaml | 25 +++++++
> include/dt-bindings/clock/en7523-clk.h | 3 +
> .../dt-bindings/reset/airoha,an7583-reset.h | 65 +++++++++++++++++++
> 3 files changed, 93 insertions(+)
> create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
>
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index fc37786ac7ed..05cd20ce3ab9 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -31,6 +31,7 @@ properties:
> compatible:
> items:
> - enum:
> + - airoha,an7583-scu
> - airoha,en7523-scu
> - airoha,en7581-scu
> - econet,en751221-scu
> @@ -57,12 +58,36 @@ properties:
> available serdes port.
> const: 1
>
> + airoha,chip-scu:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle to the Chip SCU providing the registers required
> + for configuring the PCIe related clocks and resets.
My question from an earlier version appears to be unanswered, and
Sashiko flagged it.
Brian
--
Brian Masney <masneyb@xxxxxxxxxx>