Re: [PATCH net] net/sched: cbs: fix 32-bit overflow in transmission time estimate

From: Vinicius Costa Gomes

Date: Thu Nov 19 2026 - 19:17:17 EST


Mohamed Dawod <mhm.dawod@xxxxxxxxx> writes:

> cbs_dequeue_soft() estimates when the transmission of a packet completes:
>
> q->last = now + div64_s64(len * NSEC_PER_SEC, port_rate);
>
> len is an int and NSEC_PER_SEC is 1000000000L. On 32-bit architectures
> long is 32 bits wide, so the product is computed in 32 bits and wraps
> before it is widened for div64_s64(). For a 1242 byte frame the product
> is 1242000000000 mod 2^32 = 754451456, which gives a transmission time
> of about 60 ns at 100 Mbit/s instead of about 99 us.
>
> As a result q->last stays almost equal to now and the packet sending
> time is ignored again, which is the problem 'commit 961d0e5b3294
> ("net: cbs: Fix software cbs to consider packet sending time")'
> set out to fix. The throughput becomes
>
> idleslope * port_rate / |sendslope|
>
> instead of idleslope.
>
> Measured on a BeagleBone Black (32-bit ARM, CPSW, 100 Mbit/s full
> duplex) with software CBS (offload 0), one UDP flow with a 1200 byte
> payload (1242 byte frames), sendslope = idleslope - 100000. The rate
> was read from the qdisc byte counters:
>
> idleslope [kbit/s] before [Mbit/s] after [Mbit/s]
> 10000 11.1 10
> 20000 25.0 20
> 30000 42.9 30
>
> Cast len to s64 so the multiplication is done in 64 bits on all
> architectures.
>
> Fixes: 961d0e5b3294 ("net: cbs: Fix software cbs to consider packet sending time")
> Signed-off-by: Mohamed Dawod <mhm.dawod@xxxxxxxxx>

It seems that you had tool issues and the diff ended up being
duplicated. With that mechanical/process issue fixed:

Acked-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>

It seems that it would also save CPU time, less 'qdisc_watchdog' being
scheduled without being able to make any progress.


Cheers,
--
Vinicius