[RFC PATCH v3 13/25] net: Cache leaf PISA TX flags on struct net_device

From: Luigi Rizzo

Date: Thu Nov 19 2026 - 20:09:50 EST


The sysfs attributes pisa_tx_bufs and pisa_tx_skb_heads live on the
physical DMA parent (dev->dev.parent), whereas a socket route (dst->dev)
or skb->dev may point to an upper virtual net_device (bond, VLAN,
ipvlan, etc.). Walking lower devices via netdev_walk_all_lower_dev_rcu()
on every TX allocation would be too expensive.

Add dev->pisa_tx_flags_tstamp on struct net_device to cache the leaf device
PISA TX flags and refresh them at most once every 256 jiffies via
pisa_tx_flags_refresh(). Also add the net_pisa_tx_bufs_key static key
and helpers (use_pisa_tx_bufs(), pisa_tx_bufs_gfp()) for subsequent TX
buffer patches.

Signed-off-by: Luigi Rizzo <lrizzo@xxxxxxxxxx>
---
drivers/base/core.c | 6 ++-
include/linux/device.h | 11 ++++
include/linux/netdevice.h | 4 ++
include/net/pisa.h | 81 +++++++++++++++++++++++++++++
mm/pisa-kunit.c | 3 +-
net/core/Makefile | 1 +
net/core/pisa-net.c | 104 ++++++++++++++++++++++++++++++++++++++
7 files changed, 207 insertions(+), 3 deletions(-)
create mode 100644 include/net/pisa.h
create mode 100644 net/core/pisa-net.c

diff --git a/drivers/base/core.c b/drivers/base/core.c
index df93b6b6e125e..5f1291e644c5e 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2950,7 +2950,7 @@ static DEVICE_ATTR_RW(name)

PISA_BOOL_ATTR(pisa_coherent);
PISA_BOOL_ATTR(pisa_rx_bufs);
-PISA_BOOL_ATTR(pisa_tx_bufs);
+PISA_SET_ATTR(pisa_tx_bufs, net_pisa_tx_bufs_set);
PISA_BOOL_ATTR(pisa_tx_skb_heads);
PISA_BOOL_ATTR(pisa_tx_zerocopy);

@@ -3111,8 +3111,10 @@ static void device_remove_attrs(struct device *dev)
const struct class *class = dev->class;
const struct device_type *type = dev->type;

- if (IS_ENABLED(CONFIG_PISA) && dev->dma_mask)
+ if (IS_ENABLED(CONFIG_PISA) && dev->dma_mask) {
device_remove_group(dev, &dev_attr_pisa_group);
+ net_pisa_tx_bufs_set(dev, false);
+ }

if (dev->physical_location) {
device_remove_group(dev, &dev_attr_physical_location_group);
diff --git a/include/linux/device.h b/include/linux/device.h
index e705df38e49af..0d867d8255ba5 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -817,6 +817,17 @@ struct device {
DECLARE_BITMAP(flags, DEV_FLAG_COUNT);
};

+#if defined(CONFIG_NET) && defined(CONFIG_PISA)
+int net_pisa_tx_bufs_set(struct device *dev, bool val);
+#else
+/* Without CONFIG_NET the flag still gates block-device writes (see pisa_bdev_enabled()). */
+static inline int net_pisa_tx_bufs_set(struct device *dev, bool val)
+{
+ WRITE_ONCE(dev->pisa_tx_bufs, val);
+ return 0;
+}
+#endif
+
#define __create_dev_flag_accessors(accessor_name, flag_name) \
static inline bool dev_##accessor_name(const struct device *dev) \
{ \
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 435be7880d7e5..f973faba4402c 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2161,6 +2161,7 @@ enum netdev_reg_state {
* @neighbours: List heads pointing to this device's neighbours'
* dev_list, one per address-family.
* @hwprov: Tracks which PTP performs hardware packet time stamping.
+ * @pisa_tx_flags_tstamp: Cached leaf pisa flags and timestamp.
*
* FIXME: cleanup struct net_device such that network protocol info
* moves out.
@@ -2276,6 +2277,9 @@ struct net_device {
} adj_list;

/* Read-mostly cache-line for fast-path access */
+#ifdef CONFIG_PISA
+ u32 pisa_tx_flags_tstamp;
+#endif
xdp_features_t xdp_features;
const struct xdp_metadata_ops *xdp_metadata_ops;
const struct xsk_tx_metadata_ops *xsk_tx_metadata_ops;
diff --git a/include/net/pisa.h b/include/net/pisa.h
new file mode 100644
index 0000000000000..1f95e67e99bf8
--- /dev/null
+++ b/include/net/pisa.h
@@ -0,0 +1,81 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
+/* PISA hooks for the networking stack. */
+#ifndef _NET_PISA_H
+#define _NET_PISA_H
+
+#include <linux/pisa.h>
+#include <net/sock.h>
+
+/*
+ * struct net_device caches the PISA enable flags for tx_bufs and tx_heads used
+ * by the leaf device, refreshed every 256 jiffies. The helpers below decide
+ * whether to use PISA memory for a given dst, sk, skb.
+ */
+#ifdef CONFIG_PISA
+
+enum pisa_tx_flags {
+ PISA_TX_FLAG_BUFS = BIT(0),
+ PISA_TX_XFRM_OK = BIT(2),
+ PISA_TX_TSTAMP_MASK = ~0xffU,
+};
+
+/*
+ * Static keys guarding networking hooks:
+ * - @net_pisa_tx_bufs_key: enabled while any device has pisa_tx_bufs set.
+ */
+DECLARE_STATIC_KEY_FALSE(net_pisa_tx_bufs_key);
+
+u32 pisa_tx_flags_refresh(struct net_device *dev, u32 now);
+
+/*
+ * May TX data routed through @dst use PISA pages? Those pages stay readable by
+ * every device that mapped them for as long as they are active, so only data
+ * that leaves the host in clear qualifies: IPsec payload before encryption has
+ * dst_xfrm(dst) != NULL and is rejected unless PISA_TX_XFRM_OK is set.
+ */
+static inline gfp_t __pisa_tx_gfp(const struct dst_entry *dst,
+ enum pisa_tx_flags flag)
+{
+ const struct net_device *dev;
+ u32 stamp, now;
+
+ guard(rcu)();
+ if (!dst || (dst_xfrm(dst) && !(flag & PISA_TX_XFRM_OK)))
+ return 0;
+ dev = dst_dev_rcu(dst);
+ if (!dev)
+ return 0;
+ stamp = READ_ONCE(dev->pisa_tx_flags_tstamp);
+ now = (u32)jiffies & PISA_TX_TSTAMP_MASK;
+ if (unlikely((stamp & PISA_TX_TSTAMP_MASK) != now))
+ stamp = pisa_tx_flags_refresh((struct net_device *)dev, now);
+ return (stamp & flag) ? __GFP_PISA : 0;
+}
+
+/*
+ * ============================================================================
+ * Networking hooks (every hook starts inline with a static-key check)
+ * ============================================================================
+ */
+
+/* Hook for route-based TX payload fragment selection (@net_pisa_tx_bufs_key). */
+static inline bool use_pisa_tx_bufs(const struct dst_entry *dst)
+{
+ return static_branch_unlikely(&net_pisa_tx_bufs_key) &&
+ __pisa_tx_gfp(dst, PISA_TX_FLAG_BUFS);
+}
+
+/* Hook for ESP output skb_page_frag_refill() (@net_pisa_tx_bufs_key). */
+static inline gfp_t pisa_tx_bufs_gfp(const struct sk_buff *skb)
+{
+ return static_branch_unlikely(&net_pisa_tx_bufs_key) ?
+ __pisa_tx_gfp(skb_dst(skb), PISA_TX_FLAG_BUFS | PISA_TX_XFRM_OK) : 0;
+}
+
+#else /* !CONFIG_PISA */
+
+static inline bool use_pisa_tx_bufs(const struct dst_entry *dst) { return false; }
+static inline gfp_t pisa_tx_bufs_gfp(const struct sk_buff *skb) { return 0; }
+
+#endif /* CONFIG_PISA */
+#endif /* _NET_PISA_H */
diff --git a/mm/pisa-kunit.c b/mm/pisa-kunit.c
index 4effbc8610079..d7670c76e98c5 100644
--- a/mm/pisa-kunit.c
+++ b/mm/pisa-kunit.c
@@ -578,7 +578,8 @@ static void test_dev_pisa_attrs(struct kunit *test)
kunit_check_pisa_attr(test, dev, "pisa_coherent", &dev->pisa_coherent);
kunit_check_pisa_attr(test, dev, "pisa_rx_bufs", &dev->pisa_rx_bufs);
kunit_check_pisa_attr(test, dev, "pisa_tx_zerocopy", &dev->pisa_tx_zerocopy);
- kunit_check_pisa_attr(test, dev, "pisa_tx_bufs", &dev->pisa_tx_bufs);
+ if (IS_ENABLED(CONFIG_NET))
+ kunit_check_pisa_attr(test, dev, "pisa_tx_bufs", &dev->pisa_tx_bufs);
kunit_check_pisa_attr(test, dev, "pisa_tx_skb_heads", &dev->pisa_tx_skb_heads);
device_unregister(dev);
}
diff --git a/net/core/Makefile b/net/core/Makefile
index c20e520358b8e..3c84358d6b0c0 100644
--- a/net/core/Makefile
+++ b/net/core/Makefile
@@ -52,3 +52,4 @@ obj-$(CONFIG_NET_TEST) += net_test.o
obj-$(CONFIG_NET_DEVMEM) += devmem.o
obj-$(CONFIG_DEBUG_NET) += lock_debug.o
obj-$(CONFIG_FAIL_SKB_REALLOC) += skb_fault_injection.o
+obj-$(CONFIG_PISA) += pisa-net.o
diff --git a/net/core/pisa-net.c b/net/core/pisa-net.c
new file mode 100644
index 0000000000000..6d4909c82070c
--- /dev/null
+++ b/net/core/pisa-net.c
@@ -0,0 +1,104 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/*
+ * PISA networking helpers: leaf device TX flag cache, small skb head slab
+ * cache, and MSG_ZEROCOPY user page upgrade.
+ * See Documentation/core-api/pisa.rst for the architecture overview.
+ */
+
+#include <linux/device.h>
+#include <linux/export.h>
+#include <linux/mutex.h>
+#include <linux/netdevice.h>
+#include <linux/pisa.h>
+#include <net/pisa.h>
+
+/* Enabled while at least one device has pisa_tx_bufs set. */
+DEFINE_STATIC_KEY_FALSE(net_pisa_tx_bufs_key);
+EXPORT_SYMBOL(net_pisa_tx_bufs_key);
+
+int net_pisa_tx_bufs_set(struct device *dev, bool val)
+{
+ static DEFINE_MUTEX(lock);
+
+ guard(mutex)(&lock);
+ if (dev->pisa_tx_bufs != val) {
+ WRITE_ONCE(dev->pisa_tx_bufs, val);
+ if (val)
+ static_branch_inc(&net_pisa_tx_bufs_key);
+ else
+ static_branch_dec(&net_pisa_tx_bufs_key);
+ }
+ return 0;
+}
+
+/*
+ * The sysfs attribute pisa_tx_bufs lives on the device that does DMA: the
+ * closest ancestor of a leaf net_device that has a dma_mask (dev->dev.parent,
+ * or further up behind bus glue such as virtio). A socket route (dst->dev) may
+ * instead point to an upper virtual net_device (bond, VLAN, ipvlan, etc.),
+ * whose leaves are its lower devices. Walking lower devices via
+ * netdev_walk_all_lower_dev_rcu() on every TX allocation would be too
+ * expensive, so dev->pisa_tx_flags_tstamp caches the walk result on the net_device
+ * and refreshes it at most once every 256 jiffies:
+ * bit 0 (PISA_TX_FLAG_BUFS): pisa_tx_bufs enabled on lower device(s)
+ * bits 31..8 (PISA_TX_TSTAMP_MASK): upper 24 bits of (u32)jiffies
+ */
+static u32 pisa_tx_flags(const struct net_device *dev)
+{
+ const struct device *parent = dev->dev.parent;
+ u32 flags = 0;
+
+ while (parent && !parent->dma_mask)
+ parent = parent->parent;
+ if (parent && READ_ONCE(parent->pisa_tx_bufs))
+ flags |= PISA_TX_FLAG_BUFS;
+ return flags;
+}
+
+/* MACsec encrypts in software above its lower device: its cleartext must stay out of PISA. */
+static bool pisa_tx_dev_excluded(const struct net_device *dev)
+{
+ return netif_is_macsec(dev);
+}
+
+/* A leaf has no lower devices; what its parent device is does not matter. */
+static bool pisa_tx_dev_is_leaf(const struct net_device *dev)
+{
+ return list_empty(&dev->adj_list.lower);
+}
+
+/* Every leaf must have opted in; a leaf without a DMA device (veth, tun, ...) has not. */
+static int pisa_tx_flags_walk(struct net_device *dev, struct netdev_nested_priv *priv)
+{
+ uintptr_t flags = (uintptr_t)priv->data;
+
+ if (pisa_tx_dev_excluded(dev))
+ flags = BIT(2);
+ else if (pisa_tx_dev_is_leaf(dev))
+ flags = (flags & pisa_tx_flags(dev)) | BIT(2);
+ priv->data = (void *)flags;
+ return 0;
+}
+
+/* Slow path of __pisa_tx_gfp(): refresh dev->pisa_tx_flags_tstamp. */
+u32 pisa_tx_flags_refresh(struct net_device *dev, u32 now)
+{
+ if (pisa_tx_dev_excluded(dev)) {
+ /* No flags. */
+ } else if (pisa_tx_dev_is_leaf(dev)) {
+ now |= pisa_tx_flags(dev);
+ } else {
+ struct netdev_nested_priv priv = {
+ .data = (void *)(uintptr_t)PISA_TX_FLAG_BUFS,
+ };
+
+ rcu_read_lock();
+ netdev_walk_all_lower_dev_rcu(dev, pisa_tx_flags_walk, &priv);
+ rcu_read_unlock();
+ if ((uintptr_t)priv.data & BIT(2))
+ now |= (uintptr_t)priv.data & ~BIT(2);
+ }
+ WRITE_ONCE(dev->pisa_tx_flags_tstamp, now);
+ return now;
+}
+EXPORT_SYMBOL(pisa_tx_flags_refresh);
--
2.56.1.809.ga0b61035b5-goog