Re: [PATCH v4 3/5] clk: cix: Register the Sky1 AUDSS IRQ auxiliary device
From: Jelly Jia
Date: Thu Nov 19 2026 - 20:51:45 EST
Hi Brian,
Thanks for the review.
> This, along with the defines should go in a separate commit.
Agreed. I'll move the INFO_AP_IRQC and INFO_SW_RESETN definitions
and their save/restore entries into a separate patch.
> I don't care which pattern you use but make it consistent within this
> driver.
I'll make the IRQ registration helper follow the existing reset
helper's #if IS_ENABLED() pattern, including the stub when disabled.
> Should this be a separate patch?
The reset_control_assert() error check is independent of the IRQ
integration. I'll drop that extra change from this series, leaving
the existing error-handling behaviour unchanged. The additional ret
variable will therefore no longer be needed.
> The IRQ driver uses the new pm_ptr(). Please use that.
The clock driver already uses pm_ptr() for its .pm pointer, but still
uses the SET_* PM macros. I'll switch to RUNTIME_PM_OPS() and
NOIRQ_SYSTEM_SLEEP_PM_OPS(), matching the IRQ driver, and remove
the unnecessary __maybe_unused annotations. The noirq suspend/resume
ordering will be retained.
I'll also remove the added bits.h include.
Best regards,
Jelly