Re: [PATCH net v2] gve: mark the flow rule cache out of sync when a rule update fails

From: Harshitha Ramamurthy

Date: Thu Nov 19 2026 - 21:31:44 EST


On Wed, Nov 18, 2026 at 8:46 PM Zhao Li <enderaoelyther@xxxxxxxxx> wrote:
>
> gve_adminq_configure_flow_rule() marks the flow rule cache out of sync
> only when the device accepts the command, although a failed add,
> delete or reset can leave the device state unknown.
>
> gve_reset() sends the flow rule reset command from
> gve_teardown_control_plane_resources() and then frees and reallocates
> the cache buffers. If that command fails, the cache keeps its nonzero
> rule count and stays marked in sync, but its entries are now zeroed.
> gve_get_flow_rule_entry() then finds location 0 inside the cached range,
> since every zeroed entry has location 0, and reports an all-zero
> TCP/IPv4 rule that steers to queue 0, whatever the device holds at that
> location. Queries for other locations fall outside the cached range and
> read the rules from the device again.
>
> Mark the cache out of sync whenever a flow rule command is attempted,
> so that the next query reads the rules from the device.
>
> Found by an AI code review agent; not triggered. Compile-tested with W=1.
>
> Fixes: 57718b60df9b ("gve: Add flow steering adminq commands")
> Suggested-by: Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>
> Signed-off-by: Zhao Li <enderaoelyther@xxxxxxxxx>

Thanks for the respin,
Reviewed-by: Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>

> ---
> v2:
> - mark the cache out of sync on every flow rule command instead of
> clearing it when its buffers are freed (Harshitha Ramamurthy)
> - describe the problem in more detail; drop Cc: stable
> v1: https://lore.kernel.org/netdev/20261118023429.29330-1-enderaoelyther@xxxxxxxxx/
>
> No new W=1, sparse or smatch warnings.
>
> drivers/net/ethernet/google/gve/gve_adminq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c
> index 2c848f0c23dc..d0e0d9ace3bc 100644
> --- a/drivers/net/ethernet/google/gve/gve_adminq.c
> +++ b/drivers/net/ethernet/google/gve/gve_adminq.c
> @@ -1401,8 +1401,7 @@ gve_adminq_configure_flow_rule(struct gve_priv *priv,
> sizeof(struct gve_adminq_configure_flow_rule),
> flow_rule_cmd);
>
> - if (!err)
> - priv->flow_rules_cache.rules_cache_synced = false;
> + priv->flow_rules_cache.rules_cache_synced = false;
>
> return err;
> }
>
> base-commit: e203d8a4751d48aa00eda31e3b320ba8e0d47dbf
> --
> 2.56.1
>