Re: [PATCH 0/4] soc: toshiba: tc9564: config system controller

From: Alex Elder

Date: Thu Nov 19 2026 - 21:36:38 EST


On 11/3/26 6:43 PM, Alex Elder wrote:
This series is comprised of some code that was previously sent
separately. It now incorporates a new system controller driver
that advertises clock and reset functionality, as well as regmap
access to its address range. This combination is being treated
as a new series. (Details of previous versions are below.)

The Toshiba TC9564 is an SoC that attaches to a host system via PCIe.
It includes a PCIe switch with three downstream ports. To one of
these ports an embedded PCIe endpoint is attached, and that implements
two PCI functions. BAR 4 for both PCI functions provides access to
registers controlling blocks within the SoC.

The system controller driver adds the clock and reset devices
using the mfd_add_devices() interface. The clocks and resets
are implemented by drivers included in this series.

Krzysztof Kozlowski questioned the use of the syscon for this
chip, and after some offline discussion I agreed to go without
it. This means Conor's ack won't be included, and I won't be
doing anything I said I would that was related to the syscon.

The clock and reset drivers can each stand alone, without
using a shared regmap.

Each of these drivers uses two registers. But in both cases,
the two registers are discontiguous:
clock: 0x1004 and 0x100c
reset: 0x1008 and 0x1010

It has been suggested before that separating the reset and
clock drivers has advantages, but I think in this case, the
simplicity of the combined driver (especially because of the
interleaved registers) is the better option.

For that reason, I intend to *combine* these two drivers into
a single clock controller driver that provides both clocks
and resets. The source code will reside under drivers/clk.
The combined device will have a single DTS node, defined by
a single devicetree binding, and will use a single contiguous
address range:
clock+reset: base 0x1004, size 0x10

The next version of this series would have no syscon, and
with the clock and reset support combined, it will basically
be a new series. I'll provide links back to this and older
code, but the next iteration will consist of:
- A single devicetree binding for the clock+reset combined.
- A header file defining clock and reset IDs, here:
include/dt-bindings/clock/toshiba,tc9564.h
- A single source file, drivers/clk/clk-tc9564.c (plus
updates for Kconfig and Makefile)

-Alex

-Alex

The system controller, along with its devicetree binding are new.
My hope is that this new model addresses concerns that Krzysztof
Kozlowski has expressed in prior versions of the clock and reset
code ("fold into the parent").

The clock controller driver was last posted as version 3, and all
feedback from prior versions has been addressed. This driver has
essentially been completely rewritten. There are now three clock
types (PLL, fixed factor, and gate), and each defined clock has
a parent, and the is_enabled callback is implemented for the gate
clocks.

The last version of the clock driver is here:
https://lore.kernel.org/lkml/20261012152408.3729237-1-elder@xxxxxxxxxxxx/

The reset controller driver was last posted as version 1. All
feedback received on that version has been addressed, and it's
a bit simpler than before.

The last version of the reset driver is here:
https://lore.kernel.org/lkml/20261012164354.3872326-1-elder@xxxxxxxxxxxx/

Alex Elder (4):
dt-bindings: soc: introduce toshiba,tc9564-config-syscon.yaml
soc: toshiba: tc9564: add a new syscon driver
clk: toshiba: introduce a TC9564 SoC clock driver
reset: toshiba: introduce a TC9564 SoC reset driver

.../toshiba/toshiba,tc9564-config-syscon.yaml | 68 +++++
MAINTAINERS | 23 ++
drivers/clk/Kconfig | 12 +
drivers/clk/Makefile | 1 +
drivers/clk/clk-tc9564.c | 288 ++++++++++++++++++
drivers/reset/Kconfig | 12 +
drivers/reset/Makefile | 1 +
drivers/reset/reset-tc9564.c | 135 ++++++++
drivers/soc/Kconfig | 1 +
drivers/soc/Makefile | 1 +
drivers/soc/toshiba/Kconfig | 12 +
drivers/soc/toshiba/Makefile | 3 +
drivers/soc/toshiba/tc9564-syscon.c | 42 +++
include/dt-bindings/soc/toshiba,tc9564.h | 46 +++
14 files changed, 645 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
create mode 100644 drivers/clk/clk-tc9564.c
create mode 100644 drivers/reset/reset-tc9564.c
create mode 100644 drivers/soc/toshiba/Kconfig
create mode 100644 drivers/soc/toshiba/Makefile
create mode 100644 drivers/soc/toshiba/tc9564-syscon.c
create mode 100644 include/dt-bindings/soc/toshiba,tc9564.h


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4