RE: [PATCH v9 0/5] HID: intel-thc-hid: intel-ipts: support THC IPTS ports

From: Xu, Even

Date: Thu Nov 19 2026 - 21:47:41 EST


Hi, Emfox,

Good job! Thank you for your patches. This driver fills in the remaining pieces of THC.

I've just reviewed v9 of the IPTS patch series and have a few suggestions:
1. Please separate the code by layer: put THC hardware-related handling in intel-thc, and protocol-related code in a dedicated ipts directory.
2. Please reuse existing APIs where possible. You can modify them, but please maintain compatibility. For example, the APIs related to quiescing and SPI frequency appear reusable. There may be others as well; these are just a couple of examples.
3. Please group the header files and keep them in alphabetical order.
4. Before sending the patches, run ".checkpatch.pl --strict" on all of them and fix all warnings.

One more tip:
You could send patch revisions less frequently. I noticed that you posted several versions within just a few days. That doesn't leave reviewers enough time to review them, and it can be unclear which version they should focus on. Consider leaving at least a week between revisions so reviewers have enough time to review the previous version and provide feedback. You can then address their comments in the next revision.

Thanks!

Best Regards,
Even Xu

> -----Original Message-----
> From: Emfox Zhou <emfox@xxxxxxxxxx>
> Sent: Thursday, November 19, 2026 5:12 PM
> To: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Jiri
> Kosina <jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v9 0/5] HID: intel-thc-hid: intel-ipts: support THC IPTS ports
>
> The THC ports on Tiger Lake, Lakefield, Alder Lake and Raptor Lake run in IPTS
> mode: plain SPI with a private framing instead of HIDSPI, which is all intel-thc-hid
> handles today. This adds a backend for them next to intel-quickspi and intel-
> quicki2c, on top of the same core.
>
> It is based on v7.4-rc3 with two core fix series applied, both still under review:
>
> https://lore.kernel.org/r/20261118053132.253448-1-emfox@xxxxxxxxxx
> https://lore.kernel.org/r/20261117105420.318995-1-emfox@xxxxxxxxxx
>
> One gives the DMA engines a lifetime, the other keeps a PRD table from
> overrunning after a reset, and the recovery path here relies on both.
> They overlap in intel-thc-dma.c: apply the first, then the second.
>
> Register, DMA and interrupt work goes through the exported intel-thc API, except
> in four places where the core has no call for it: the reset, port-supported and
> quiesce-state bits of THC_M_PRT_CONTROL are accessed directly. Nothing
> outside the new directory changes except Kconfig and Makefile.
>
> The hardware facts - port IDs, configuration block layout, frame codes and header
> sizes - come from the ithc driver linux-surface ships, at
> https://github.com/quo/ithc-linux 6d53c9c (dual licensed GPL-2.0 / BSD-2-
> Clause); no code is taken from it. The layout, the frame format and the ordering
> between quiesce, interrupt configuration and the DMA engines are the parts most
> likely to need scrutiny; each is argued in the commit message that relies on it. All
> of it was confirmed on a Surface Pro 8 with a 045e:0c37 controller.
>
> The first four patches each leave a state that builds and loads: port bring-up, DMA
> and interrupts, HID registration, system sleep. The fifth documents the frame
> format and the IPTS handshake.
>
> Link to v8: https://lore.kernel.org/r/20261118065725.673090-1-
> emfox@xxxxxxxxxx
>
> Changes in v9:
>
> - The reset count a feature answer is compared with is sampled inside
> the send, under the lock a reset must take, so only one that started
> after the frame went out can change it.
>
> - The interrupt is masked before a resume brings the port back, as probe
> already does.
>
> - A failed reset no longer wakes the queue, which no waiter could act
> on: the port stays masked until it is started again.
>
> Emfox Zhou (5):
> HID: intel-thc-hid: intel-ipts: bring up the port
> HID: intel-thc-hid: intel-ipts: receive reports
> HID: intel-thc-hid: intel-ipts: add the HID device
> HID: intel-thc-hid: intel-ipts: handle system sleep
> HID: intel-thc-hid: intel-ipts: document the IPTS mode
>
> Documentation/hid/intel-thc-hid.rst | 109 +-
> drivers/hid/intel-thc-hid/Kconfig | 14 +
> drivers/hid/intel-thc-hid/Makefile | 4 +
> drivers/hid/intel-thc-hid/intel-ipts/ipts.c | 989 ++++++++++++++++++
> drivers/hid/intel-thc-hid/intel-ipts/ipts.h | 201 ++++
> .../hid/intel-thc-hid/intel-ipts/pci-ipts.c | 201 ++++
> 6 files changed, 1517 insertions(+), 1 deletion(-) create mode 100644
> drivers/hid/intel-thc-hid/intel-ipts/ipts.c
> create mode 100644 drivers/hid/intel-thc-hid/intel-ipts/ipts.h
> create mode 100644 drivers/hid/intel-thc-hid/intel-ipts/pci-ipts.c
>
>
> base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3