[PATCH v3 08/11] fs/drop_caches: convert drop_pagecache_sb() to super_iter_inodes()
From: Huang Shijie
Date: Thu Nov 19 2026 - 22:14:47 EST
Convert drop_pagecache_sb() to super_iter_inodes().
No functional change.
Signed-off-by: Huang Shijie <huangsj@xxxxxxxx>
---
fs/drop_caches.c | 45 +++++++++++++++++----------------------------
1 file changed, 17 insertions(+), 28 deletions(-)
diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index 28c5fb9c7357..68f1926e0c0e 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c
@@ -17,39 +17,28 @@
/* A global variable is a bit ugly, but it keeps the code simple */
static int sysctl_drop_caches;
-static void drop_pagecache_sb(struct super_block *sb, void *unused)
+static bool invalidate_inode_eligible(struct inode *inode, void *priv)
+{
+ /*
+ * We skip inodes without pages but we deliberately won't
+ * in case we need to reschedule to avoid softlockups.
+ */
+ return !mapping_empty(inode->i_mapping) || need_resched();
+}
+
+static int invalidate_inode_fn(struct inode *inode, void *priv)
{
- struct inode *inode, *toput_inode = NULL;
+ invalidate_mapping_pages(inode->i_mapping, 0, -1);
+ return INO_ITER_RET_NEXT;
+}
+static void drop_pagecache_sb(struct super_block *sb, void *unused)
+{
if (sb->s_bdi == &noop_backing_dev_info)
return;
- spin_lock(&sb->s_inode_list_lock);
- list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
- spin_lock(&inode->i_lock);
- /*
- * We must skip inodes in unusual state. We may also skip
- * inodes without pages but we deliberately won't in case
- * we need to reschedule to avoid softlockups.
- */
- if ((inode_state_read(inode) & (I_FREEING | I_WILL_FREE | I_NEW)) ||
- (mapping_empty(inode->i_mapping) && !need_resched())) {
- spin_unlock(&inode->i_lock);
- continue;
- }
- __iget(inode);
- spin_unlock(&inode->i_lock);
- spin_unlock(&sb->s_inode_list_lock);
-
- invalidate_mapping_pages(inode->i_mapping, 0, -1);
- iput(toput_inode);
- toput_inode = inode;
-
- cond_resched();
- spin_lock(&sb->s_inode_list_lock);
- }
- spin_unlock(&sb->s_inode_list_lock);
- iput(toput_inode);
+ super_iter_inodes(sb, invalidate_inode_fn,
+ invalidate_inode_eligible, NULL, 0);
}
static int drop_caches_sysctl_handler(const struct ctl_table *table, int write,
--
2.53.0