Re: [PATCH v2] mm/page_owner: fix double decrement of stack count on unpoison
From: Miaohe Lin
Date: Thu Nov 19 2026 - 22:46:24 EST
On 2026/11/20 7:48, Nilay Vaish wrote:
> page_owner counts, for each allocation stack, how many pages allocated
> from that stack are still in use. The count is incremented when a page
> is allocated and decremented in __reset_page_owner() when it is freed.
>
> A page that is hwpoisoned while in use and later unpoisoned passes
> through free_pages_prepare() twice:
>
> 1. On poisoning, the last reference is dropped. free_pages_prepare()
> calls reset_page_owner() but, because the page is PageHWPoison(),
> keeps it off the free lists.
>
> 2. On unpoisoning, unpoison_memory() drops the poison reference and
> free_pages_prepare() calls reset_page_owner() again, this time
> really freeing the page.
>
> __reset_page_owner() decrements the stack count both times, although
> the page was allocated only once. The first call clears
> PAGE_EXT_OWNER_ALLOCATED, but the second call never checks it.
>
> If this drives the count to zero while the stack is still in use,
> stackdepot treats the record as freed and warns on every later
> allocation or free that uses the same stack:
>
> dec_stack_record_count: refcount went to 0 for 92274844 handle
> WARNING: lib/stackdepot.c:517 at depot_fetch_stack+0x5c/0x70
> Call Trace:
> __set_page_owner+0x110/0x290
> get_page_from_freelist+0x1225/0x1440
> __alloc_frozen_pages_noprof+0x1fc/0x1b00
> __folio_alloc_noprof+0x12/0xa0
> alloc_migration_target+0x81/0x1e0
> migrate_pages_batch+0x1f2/0x14c0
> migrate_pages+0x9c3/0xca0
> soft_offline_page+0x189/0x570
>
> A single soft offline followed by an unpoison is enough to trigger it,
> because the migration-target stack that the offlined page is accounted
> to usually has very few pages.
>
> Fix it by decrementing the stack count only if PAGE_EXT_OWNER_ALLOCATED
> was still set, i.e. only the first time the page is freed.
>
> To reproduce, boot with page_owner=on and CONFIG_HWPOISON_INJECT, soft
> offline anonymous pages with madvise(MADV_SOFT_OFFLINE), and unpoison
> each old PFN through debugfs hwpoison/unpoison-pfn. Without this patch
Oh wow, this issue should be very easy to reproduce, and it has been around for
quite some time. When I tested earlier, CONFIG_PAGE_OWNER was enabled, but I didn't
add page_owner=on to the boot parameters. :(
> the first cycle prints the message above and 2200 cycles produce 6597
> warnings. With it, the same run is clean and all stack counts return
> to their initial values.
>
> Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Jose A. Perez de Azpillaga <azpijr@xxxxxxxxx>
> Reviewed-by: Oscar Salvador (SUSE) <osalvador@xxxxxxxxxx>
> Signed-off-by: Nilay Vaish <nilayvaish@xxxxxxxxxx>
Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Thanks.
.