[PATCH 5/9] gpu: nova-core: gsp: fix resume_gsp_rm()'s error messages

From: John Hubbard

Date: Thu Nov 19 2026 - 23:47:57 EST


resume_gsp_rm()'s error messages have two problems:

* Both messages open with "Sequencer:", which assumes that the function
knows which code is calling it, and that that will never change. This
kind of tight coupling is almost never desirable in well-structured
code.

* One message prints the SEC2 mailbox value in decimal. That needlessly
complicates looking up the error code, given that Open RM documents
those values in hex.

Remove the sequencer's name from both messages and name the GSP-RM
resume instead, and print the SEC2 mailbox value in hexadecimal.

Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
---
drivers/gpu/nova-core/gsp/load_exec.rs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/nova-core/gsp/load_exec.rs b/drivers/gpu/nova-core/gsp/load_exec.rs
index ccbfcbfe3ce5..bf465ac1151f 100644
--- a/drivers/gpu/nova-core/gsp/load_exec.rs
+++ b/drivers/gpu/nova-core/gsp/load_exec.rs
@@ -62,7 +62,11 @@ pub(super) fn resume_gsp_rm(
// Verify SEC2 completed successfully by checking its mailbox for errors.
let mbox0 = sec2_falcon.read_mailbox0();
if mbox0 != 0 {
- dev_err!(dev, "Sequencer: sec2 errors: {:?}\n", mbox0);
+ dev_err!(
+ dev,
+ "SEC2 reported an error while resuming GSP-RM: {:#x}\n",
+ mbox0
+ );
return Err(EIO);
}

@@ -71,7 +75,7 @@ pub(super) fn resume_gsp_rm(

// Verify the GSP's RISC-V core is active indicating successful GSP boot.
if !gsp_falcon.is_riscv_active() {
- dev_err!(dev, "Sequencer: RISC-V core is not active\n");
+ dev_err!(dev, "GSP RISC-V core is not active after resuming GSP-RM\n");
return Err(EIO);
}
Ok(())
--
2.56.1