[PATCH 6/9] gpu: nova-core: falcon: select the BAR2 engine ID for framebuffer DMA

From: John Hubbard

Date: Thu Nov 19 2026 - 23:48:21 EST


When Open RM loads a binary from the framebuffer into a falcon by DMA,
it selects BAR2 as the MMU engine ID of the transfer, in the falcon's
FBIF_TRANSCFG register. Nova-core's definition of the register has no
field for the engine ID, so the DMA transfer code has no way to select
one.

Add the field, and select the BAR2 engine ID for a DMA transfer whose
source is the framebuffer.

Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
---
drivers/gpu/nova-core/falcon.rs | 24 ++++++++++++++++++++++--
drivers/gpu/nova-core/regs.rs | 2 ++
2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs
index 28c37c82b8a2..75954856ad7c 100644
--- a/drivers/gpu/nova-core/falcon.rs
+++ b/drivers/gpu/nova-core/falcon.rs
@@ -175,6 +175,18 @@ pub(crate) enum FalconFbifMemType with From<Bounded<u32, 1>> {
}
}

+bounded_enum! {
+ /// MMU engine ID under which the falcon's FBIF issues a DMA transfer. A kernel driver should
+ /// select `Bar2Fn0`. (Only GPU firmware selects `Own`.)
+ #[derive(Debug, Copy, Clone)]
+ pub(crate) enum FalconFbifEngineIdFlag with From<Bounded<u32, 1>> {
+ /// The engine ID of PCI function 0's BAR2.
+ Bar2Fn0 = 0,
+ /// The falcon's own engine ID.
+ Own = 1,
+ }
+}
+
const PFALCON_REGION_SIZE: usize = SZ_4K;
const PFALCON2_REGION_SIZE: usize = SZ_4K;

@@ -607,8 +619,16 @@ fn dma_wr(

self.pfalcon
.update(regs::NV_PFALCON_FBIF_TRANSCFG::at(0), |v| {
- v.with_target(fbif_target)
- .with_mem_type(FalconFbifMemType::Physical)
+ let v = v
+ .with_target(fbif_target)
+ .with_mem_type(FalconFbifMemType::Physical);
+
+ match src {
+ FalconDmaSource::Sysmem(_) => v,
+ FalconDmaSource::Framebuffer { .. } => {
+ v.with_engine_id_flag(FalconFbifEngineIdFlag::Bar2Fn0)
+ }
+ }
});

for pos in (0..num_transfers).map(|i| i * DMA_LEN) {
diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
index dfe7944cf1e7..050054a2b23d 100644
--- a/drivers/gpu/nova-core/regs.rs
+++ b/drivers/gpu/nova-core/regs.rs
@@ -18,6 +18,7 @@
DmaTrfCmdSize,
FalconCoreRev,
FalconCoreRevSubversion,
+ FalconFbifEngineIdFlag,
FalconFbifMemType,
FalconFbifTarget,
FalconMem,
@@ -291,6 +292,7 @@ pub(crate) fn usable_fb_size(self) -> u64 {
}

pub(crate) NV_PFALCON_FBIF_TRANSCFG(u32)[8] @ 0x00000600 {
+ 16:16 engine_id_flag => FalconFbifEngineIdFlag;
2:2 mem_type => FalconFbifMemType;
1:0 target ?=> FalconFbifTarget;
}
--
2.56.1