Re: [PATCH] apparmor: fix label replacement compiled out of __label_insert()
From: Guicai Ma
Date: Fri Nov 20 2026 - 00:45:13 EST
On Thu, Nov 19, 2026 at 08:36:50PM +0000, Andrew Kroh wrote:
> - AA_BUG(!__label_replace(this, label));
> + replaced = __label_replace(this, label);
> + AA_BUG(!replaced);
Nice catch. I also checked the other AA_BUG() sites in security/apparmor/
for side effects and found none, and verified the a//&b profile
replacement reproducer on arm64 with
CONFIG_SECURITY_APPARMOR_DEBUG_ASSERTS=n.
Reviewed-by: Guicai Ma <maguicai@xxxxxxxxxx>
Tested-by: Guicai Ma <maguicai@xxxxxxxxxx>