Re: [PATCH] tools/sched_ext: Add "arena" BTF type tag to the __arena qualifier

From: Andrea Righi

Date: Fri Nov 20 2026 - 01:14:53 EST


Hi Shaojie,

On Thu, Nov 19, 2026 at 06:26:13PM +0800, Shaojie Sun wrote:
> tools/testing/selftests/bpf/libarena marks __arena types with
> btf_type_tag("arena") so that whether a type belongs to an arena can be
> determined from BTF alone:
>
> commit a0fa68d8ce75 ("selftests/bpf: libarena: Add "arena" BTF type
> tag to __arena qualifier")
>
> tools/sched_ext defines the same __arena qualifier but without the
> "arena" BTF type tag. Add the tag so that both describe arena types the
> same way.
>
> checkpatch reports a false positive on the new definition:
>
> ERROR: Macros with complex values should be enclosed in parentheses
>
> The macro value is a sequence of declaration attributes, not an
> expression, so it can neither be parenthesized nor wrapped in a
> do-while loop. The selftests copy of the qualifier has the very same
> definition and triggers the same warning.
>
> Signed-off-by: Shaojie Sun <sunshaojie@xxxxxxxxxx>
> ---
> tools/sched_ext/include/scx/bpf_arena_common.bpf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> index 2043d66940ea..fb796b356f86 100644
> --- a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> +++ b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
> @@ -16,7 +16,7 @@
>
> #if defined(__BPF_FEATURE_ADDR_SPACE_CAST) && !defined(BPF_ARENA_FORCE_ASM)
> #ifndef __arena
> -#define __arena __attribute__((address_space(1)))
> +#define __arena __attribute__((address_space(1))) __attribute__((btf_type_tag("arena")))

Can you add the BTF type tag also to the fallback of __arena, so that it
covers older LLVM versions and BPF_ARENA_FORCE_ASM as well? (see below)

Longer term (not for this patch), we should probably move these
definitions into a shared BPF header used by both sched_ext and
libarena, to avoid keeping duplicate copies in sync. That can be a
separate cleanup.

With the change below:

Reviewed-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks,
-Andrea

tools/sched_ext/include/scx/bpf_arena_common.bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
index fb796b356f864..9f63732181065 100644
--- a/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
+++ b/tools/sched_ext/include/scx/bpf_arena_common.bpf.h
@@ -74,7 +74,7 @@
, [as]"i"((dst_as << 16) | src_as));
#endif

-#define __arena
+#define __arena __attribute__((btf_type_tag("arena")))
#define __arena_global SEC(".addr_space.1")
#define cast_kern(ptr) bpf_addr_space_cast(ptr, 0, 1)
#define cast_user(ptr) bpf_addr_space_cast(ptr, 1, 0)

> #endif
> #define __arena_global __attribute__((address_space(1)))
> #define cast_kern(ptr) /* nop for bpf prog. emitted by LLVM */
> --
> 2.50.1
>