[PATCH] tools/wmi: Check the Dell SMBIOS buffer size read
From: Zhu Jun
Date: Fri Nov 20 2026 - 01:19:38 EST
query_buffer_size() ignores an incomplete read, and main() can use a
partial size or reach free() before buffer has been initialized.
Require a complete size read and return failure before allocating or
freeing a buffer when the size is unavailable.
Fixes: 9d64fc08f6fe ("tools/wmi: add a sample for dell smbios communication over WMI")
Signed-off-by: Zhu Jun <zhujun2@xxxxxxxxxxxxxxxxxxxx>
---
tools/wmi/dell-smbios-example.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tools/wmi/dell-smbios-example.c b/tools/wmi/dell-smbios-example.c
index 1f3e7ab14b68..a4c63a6a0ee3 100644
--- a/tools/wmi/dell-smbios-example.c
+++ b/tools/wmi/dell-smbios-example.c
@@ -143,13 +143,15 @@ static int activate_token(struct dell_wmi_smbios_buffer *buffer,
static int query_buffer_size(__u64 *buffer_size)
{
FILE *f;
+ int ret;
f = fopen(ioctl_devfs, "rb");
if (!f)
- return -EINVAL;
- fread(buffer_size, sizeof(__u64), 1, f);
+ return -errno;
+ ret = fread(buffer_size, sizeof(*buffer_size), 1, f) == 1 ? 0 : -EIO;
fclose(f);
- return EXIT_SUCCESS;
+
+ return ret;
}
int main(void)
@@ -159,9 +161,9 @@ int main(void)
__u64 value = 0;
ret = query_buffer_size(&value);
- if (ret == EXIT_FAILURE || !value) {
+ if (ret || !value) {
printf("Unable to read buffer size\n");
- goto out;
+ return EXIT_FAILURE;
}
printf("Detected required buffer size %lld\n", value);