Re: [PATCH v2] pinctrl: stm32: Fix reset control leak in stm32_pctl_probe() error paths

From: Xiangwu Lai

Date: Fri Nov 20 2026 - 01:34:13 EST


Hi Antonio,

Thanks for the historical context. For the record, this is about:

[PATCH v3] pinctrl: stm32: Fix reset control leak in stm32_pctl_probe() error paths
https://lore.kernel.org/r/20261116031043.502-1-laixiangwu@xxxxxxxxxxxxxxxxxxxx

On Thu, Nov 19, 2026 at 07:27:19PM +0100, Antonio Borneo wrote:
> The driver's "resets" property is not currently used by any upstream DT.
> Using it is also problematic, as asserting the reset affects all GPIOs in
> the bank, including those already configured by the bootloader or secure
> world. The current driver uses this only to deassert the reset during
> probe.

Thanks for the background -- I had a look and could not find any in-tree
user of the property either: the only rstc use sites in the driver are
the of_reset_control_get_exclusive() in the probe bank loop and the
deassert at probe time.

> This patch has the "Fixes:" tag. Whatever the evolution of this thread,
> I think this patch should be taken for backport in stable then,
> eventually, followed by the "resets" removal.

That order makes sense to me as well: fix the leak first and let it
reach stable, with the "resets" property removal as a follow-up cleanup.
The patch is ready as-is (v3 above); no further changes are planned from
my side, so it can be picked up whenever convenient.

Thanks to both of you for the review.

Best regards,
Xiangwu Lai