[PATCH v2 0/2] can: virtio: fix NAPI stall and virtqueue use before DRIVER_OK

From: Seonghyeon Lim via B4 Relay

Date: Fri Nov 20 2026 - 01:58:03 EST


This series fixes two issues in the virtio CAN driver.

Patch 1 fixes an RX/TX stall when an interrupt arrives after the START
command but before NAPI is enabled in virtio_can_open().

Patch 2 calls virtio_device_ready() before the first virtqueue use in
probe and restore. Without it, resume hangs if the interface was up.

Patch 1 goes first: without patch 2, restore hangs waiting for the
START reply before it reaches that window, so patch 2 alone would
expose the stall.

The interrupt handlers could also use virtqueue_napi_schedule() like
virtio-net does. I left that for a follow-up cleanup.

Tested with QEMU 8.2 and vhost-device-can:
- With the interface up, suspend/resume (pm_test=devices) hangs
without patch 2 and completes with the series.
- With a temporary delay before napi_enable() and continuous traffic,
RX interrupts arrive while NAPI is disabled and napi_schedule_prep()
fails. With patch 1, NAPI is scheduled right after napi_enable() and
the RX poll runs without waiting for another interrupt.
vhost-device-can keeps sending interrupts, which hides the stall
without patch 1.
- RX traffic and repeated down/up work. No lockdep warnings.

---
Changes in v2:
- Add patch 1 for the NAPI stall reported by sashiko-bot. With patch 2
the restore path can reach it (Michael's question about callbacks
after virtio_device_ready()).
- Patch 2: describe the callbacks, add the hung task trace and
Cc: stable.
- Link to v1: https://patch.msgid.link/20261111-virtio-can-ready-v1-1-0b4dd020af0b@xxxxxxxxx

---
Seonghyeon Lim (2):
can: virtio: fix RX/TX stall on interrupt before NAPI is enabled
can: virtio: fix virtqueue use before DRIVER_OK

drivers/net/can/virtio_can.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
change-id: 20261111-virtio-can-ready-85cefff06a84

Best regards,
--
Seonghyeon Lim <forfortuna@xxxxxxxxx>