Re: [PATCH] staging: greybus: light: Use sysfs_emit() instead of sprintf()

From: Greg KH

Date: Fri Nov 20 2026 - 02:07:09 EST


On Tue, Nov 10, 2026 at 12:00:59AM +0100, Platon Miller wrote:
> Use sysfs_emit() instead of sprintf() in sysfs show attributes
> (fade_##__dir##_show and color_show). sysfs_emit() is specifically
> designed for sysfs attributes, is PAGE_SIZE-aware, and avoids potential
> buffer overflows.
>
> Signed-off-by: Platon Miller <platon.ksenzenkokk@xxxxxxxxx>
> ---
> drivers/staging/greybus/light.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index cab02b5da..2689f9a75 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \
> struct led_classdev *cdev = dev_get_drvdata(dev); \
> struct gb_channel *channel = get_channel_from_cdev(cdev); \
> \
> - return sprintf(buf, "%u\n", channel->fade_##__dir); \
> + return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \
> } \
> \
> static ssize_t fade_##__dir##_store(struct device *dev, \
> @@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr,
> struct led_classdev *cdev = dev_get_drvdata(dev);
> struct gb_channel *channel = get_channel_from_cdev(cdev);
>
> - return sprintf(buf, "0x%08x\n", channel->color);
> + return sysfs_emit(buf, "0x%08x\n", channel->color);

sprintf() is just fine to use here.

thanks,

greg k-h