Re: [PATCH 0/3] staging: sm750fb: Clean up helpers and fix DAC power-off handling
From: Greg KH
Date: Fri Nov 20 2026 - 02:13:34 EST
On Sat, Nov 14, 2026 at 01:02:04PM +0300, Ali Köse wrote:
> This series replaces the set_DAC macro with a local static function,
> corrects the DAC power-off bit handling, and removes an empty software
> I2C acknowledgement helper and its ineffective parameter.
>
> The first and third patches preserve existing behavior. The second
> patch maps the extracted 0/1 DAC state to bit 20 rather than OR-ing it
> into bit 0 of MISC_CTRL.
>
> Based on staging-next at 6628e7d4c6b (Linux 7.4-rc1).
>
> Validation:
> - All SM750 driver objects compiled and linked into sm750fb.o with W=1,
> CONFIG_FB=y, CONFIG_STAGING=y, and CONFIG_FB_SM750=m.
> - A standalone mocked-register test checked 72 DAC state and register
> preservation cases: 36 failed before the fix and none failed afterward.
> - checkpatch.pl reported no errors or warnings.
> - git diff --check passed.
>
> Hardware testing was not performed.
Please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh