Re: [PATCH v2 4/7] thunderbolt: add platform NHI driver

From: Chunfeng Yun (云春峰)

Date: Fri Nov 20 2026 - 03:16:47 EST


On 二, 2026-11-17 at 13:52 +0100, mika.westerberg@xxxxxxxxxxxxxxx wrote:
> Hi,
>
> On Tue, Nov 17, 2026 at 12:14:29PM +0000, Chunfeng Yun (云春峰) wrote:
> > On 二, 2026-11-10 at 15:37 +0100, Mika Westerberg wrote:
> > > On Tue, Nov 10, 2026 at 07:48:52PM +0800, Chunfeng Yun wrote:
> > > >  
> > > > -void nhi_enable_int_throttling(struct tb_nhi *nhi);
> > > >  void nhi_disable_interrupts(struct tb_nhi *nhi);
> > > >  irqreturn_t tb_nhi_isr(int irq, void *data);
> > > >  irqreturn_t tb_ring_msix(int irq, void *data);
> > > > diff --git a/drivers/thunderbolt/pci.c
> > > > b/drivers/thunderbolt/pci.c
> > > > index 9379c598a221..698f47ec63da 100644
> > > > --- a/drivers/thunderbolt/pci.c
> > > > +++ b/drivers/thunderbolt/pci.c
> > > > @@ -736,4 +736,5 @@ static struct pci_driver nhi_driver = {
> > > >   .shutdown = nhi_pci_shutdown,
> > > >   .driver.pm = &tb_nhi_pm_ops,
> > > >  };
> > > > +
> > >
> > > I guess this is unintented change?
> > >
> > will drop it
> >
> > > >  module_pci_driver(nhi_driver);
> > > > diff --git a/drivers/thunderbolt/platform.c
> > > > b/drivers/thunderbolt/platform.c
> > > > new file mode 100644
> > > > index 000000000000..3562b6c7ea7d
> > > > --- /dev/null
> > > > +++ b/drivers/thunderbolt/platform.c
> > > > @@ -0,0 +1,172 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > +/*
> > > > + * Thunderbolt driver - NHI driver (Platform bus specific
> > > > implementation)
> > > > + *
> > > > + * Author: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > > > + */
> > > > +
> > > > +#include <linux/acpi.h>
> > > > +#include <linux/interrupt.h>
> > > > +#include <linux/errno.h>
> > > > +#include <linux/of.h>
> > > > +#include <linux/platform_device.h>
> > > > +#include <linux/pm_runtime.h>
> > > > +#include <linux/pm_wakeirq.h>
> > > > +#include <linux/slab.h>
> > > > +
> > > > +#include "nhi.h"
> > > > +#include "tb.h"
> > > > +
> > > > +static int nhi_platform_init(struct tb_nhi *nhi)
> > > > +{
> > > > + /* avoid device link fail for pcie tunnel */
> > >
> > > Do you have the ACPI _DSD there in place? 
> > Yes, we use the same uefi as WoA which pass Windows HLK and usb-if
> > certitfication
> >
> > > Then I don't think you need
> > > these. And "pcie" -> "PCIe" everywhere (except in code).
> > ACK
> >
> > >
> > > > + pm_runtime_set_active(nhi->dev);
> > > > + pm_runtime_get_noresume(nhi->dev);
> > > > + pm_runtime_enable(nhi->dev);
> > > > +
> > > > + device_set_wakeup_capable(nhi->dev, true);
> > > > + device_enable_async_suspend(nhi->dev);
> > >
> > > I also suggest not to enable all the fancy power management until
> > > you
> > > have
> > > the basic stuff like tunneling fully functional.
> > I'm not sure understand what you mean.
> >
> > if you mean the function test:
> > I already test usb4net, usb3 tunnel, PCIe tunnel and dp tunnel data
> > transfers, and also runtime suspend/resume and system
> > suspend/resume.
> >
> > if you mean when to enable pm:
> > do you mean enable pm at the enable of tb_nhi_probe()?
> >
> > + pm_runtime_set_active(nhi->dev);
> > + pm_runtime_get_noresume(nhi->dev);
> > + pm_runtime_enable(nhi->dev);
> >
> > these three line shall be put before nhi_select_cm(), otherwise, it
> > fail to link PCIe devices, and I will check it again.
> >
> > + device_set_wakeup_capable(nhi->dev, true);
> > + device_enable_async_suspend(nhi->dev);
> >
> > these two line can be put at the end of probe.
>
> I meant device_enable_async_suspend() it's not stricly required and
> we
> don't do it elsewhere so I would leave it out now and then add it
> everywhere later.

I look at the PCI core code, seems it already enables async suspend for
every PCI device during device enumeration by default.

see: pci_pm_init() (drivers/pci/pci.c)

Unlike the PCI bus, the platform bus does not automatically enable it
for platform devices, but for usb devices, usually enable it because
the standardized tree topology with well-defined dependencies.

Due to we explicitly create dev-link with xHCI/PCIe controller devices,
it is safe to enable it, then keep the same way as thunderbolt/pci.c
does.

Thanks
>
> >
> > if you have any suggestions, please describe more details, I will
> > try
> > it.
> >
> > >
> > >
> > > >