Re: [PATCH] usb: typec: tcpm: qcom: Release connector fwnode after regulator lookup
From: Greg KH
Date: Fri Nov 20 2026 - 03:17:30 EST
On Thu, Nov 12, 2026 at 10:18:36AM +0800, Xiangwu Lai wrote:
> pmic_typec_port_probe() looks up the "connector" child node with
> device_get_named_child_node(), which takes a reference on the
> returned fwnode. The node is only used for the VBUS regulator lookup
> from the connector node and the reference is never dropped, so every
> probe leaks one fwnode reference.
>
> Release the reference right after the regulator lookup, mirroring
> the parent driver which already manages its own reference on the
> same node.
>
> Fixes: 506927b6bf29 ("usb: typec: tcpm: qcom: prefer VBUS supply from the connector node")
> Signed-off-by: Xiangwu Lai <laixiangwu@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 ++
> 1 file changed, 2 insertions(+)
I picked up an earlier version of this:
https://lore.kernel.org/r/20261025-typec-of-fix-v1-1-06bfc16a7846@xxxxxxx