Re: [PATCH v5 12/17] mm/khugepaged: convert to LRU refs based operations for MGLRU
From: KunWu Chan
Date: Fri Nov 20 2026 - 03:22:06 EST
On Thu, Nov 19, 2026 at 5:03 AM Kairui Song via B4 Relay
<devnull+kasong.tencent.com@xxxxxxxxxx> wrote:
>
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> For MGLRU, PG_referenced is only the lowest bit of the folio LRU refs
> count, so folios with nonzero even refs no longer have the bit set.
> folio_pte_referenced() testing the raw bit misses hot folios at
> refs 2, 4 or 6, under-counting the referenced folios of a candidate range
> and aborting otherwise good collapses with SCAN_LACK_REFERENCED_PAGE.
>
> Test the refs count directly when MGLRU is enabled, mirroring the
> smaps conversion. The classical LRU keeps the plain bit test.
>
> Tested-by: Zhao Zhenzhuo <zhaozhengzhuo@xxxxxxxxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
> ---
> mm/khugepaged.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 4bbe319ef86f..68f7a30e36be 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -579,7 +579,9 @@ static bool folio_pte_referenced(struct folio *folio,
> struct vm_area_struct *vma, unsigned long addr, pte_t pteval)
> {
> /* The folio was referenced previously ... */
> - if (folio_test_young(folio) || folio_test_referenced(folio))
> + if (folio_test_young(folio))
> + return true;
> + if (folio_check_lru_refs(folio))
> return true;
> /* ... or the PTE mapping was recently used */
> return pte_young(pteval) || mmu_notifier_test_young(vma->vm_mm, addr);
>
> --
> 2.56.1
>
>
Reviewed-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>
Thanks,
Kunwu