Re: [PATCH v3 2/2] media: qcom: camss: Add Glymur-specific resources
From: Loic Poulain
Date: Fri Nov 20 2026 - 03:31:17 EST
On Thu, Nov 19, 2026 at 4:04 PM Nihal Kumar Gupta
<nihal.gupta@xxxxxxxxxxxxxxxx> wrote:
>
> Glymur previously reused the X1E80100 CAMSS resources, where port@3
> selected CSIPHY4 through x1e80100 csiphy_res[3].csiphy.id.
>
> Add Glymur-specific CSIPHY resources so ports 0, 1 and 2 map to hardware
> PHY ids 0, 1 and 4. The remaining CAMSS resources continue to reuse the
> X1E80100 CAMSS resources.
>
> Signed-off-by: Nihal Kumar Gupta <nihal.gupta@xxxxxxxxxxxxxxxx>
Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss.c | 42 ++++++++++++++++++++++++++++++-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index f8e5cf9f3ff09e96d3b48cd5628489715385cc5c..f3cab9ecef04273e09b81ee0cd4e31ca45d1c915 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4103,6 +4103,30 @@ static const struct resources_icc icc_res_sa8775p[] = {
> },
> };
>
> +static const struct camss_subdev_resources csiphy_res_glymur[] = {
> + /* CSIPHY0 */
> + {
> + .csiphy = {
> + .id = 0,
> + .formats = &csiphy_formats_sdm845
> + },
> + },
> + /* CSIPHY1 */
> + {
> + .csiphy = {
> + .id = 1,
> + .formats = &csiphy_formats_sdm845
> + },
> + },
> + /* CSIPHY4 */
> + {
> + .csiphy = {
> + .id = 4,
> + .formats = &csiphy_formats_sdm845
> + },
> + },
> +};
> +
> static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
> /* CSIPHY0 */
> {
> @@ -5572,6 +5596,22 @@ static void camss_remove(struct platform_device *pdev)
> camss_genpd_cleanup(camss);
> }
>
> +static const struct camss_resources glymur_resources = {
> + .version = CAMSS_X1E80100,
> + .pd_name = "top",
> + .csiphy_res = csiphy_res_glymur,
> + .tpg_res = tpg_res_x1e80100,
> + .csid_res = csid_res_x1e80100,
> + .vfe_res = vfe_res_x1e80100,
> + .csid_wrapper_res = &csid_wrapper_res_x1e80100,
> + .icc_res = icc_res_x1e80100,
> + .icc_path_num = ARRAY_SIZE(icc_res_x1e80100),
> + .csiphy_num = ARRAY_SIZE(csiphy_res_glymur),
> + .tpg_num = ARRAY_SIZE(tpg_res_x1e80100),
> + .csid_num = ARRAY_SIZE(csid_res_x1e80100),
> + .vfe_num = ARRAY_SIZE(vfe_res_x1e80100),
> +};
> +
> static const struct camss_resources msm8916_resources = {
> .version = CAMSS_8x16,
> .csiphy_res = csiphy_res_8x16,
> @@ -5806,6 +5846,7 @@ static const struct camss_resources x1e80100_resources = {
> };
>
> static const struct of_device_id camss_dt_match[] = {
> + { .compatible = "qcom,glymur-camss", .data = &glymur_resources },
> { .compatible = "qcom,msm8916-camss", .data = &msm8916_resources },
> { .compatible = "qcom,msm8939-camss", .data = &msm8939_resources },
> { .compatible = "qcom,msm8953-camss", .data = &msm8953_resources },
> @@ -5824,7 +5865,6 @@ static const struct of_device_id camss_dt_match[] = {
> { .compatible = "qcom,sm8550-camss", .data = &sm8550_resources },
> { .compatible = "qcom,sm8650-camss", .data = &sm8650_resources },
> { .compatible = "qcom,x1e80100-camss", .data = &x1e80100_resources },
> - { .compatible = "qcom,glymur-camss", .data = &x1e80100_resources },
> { }
> };
>
>
> --
> 2.34.1
>