Re: [PATCH net v5 07/14] net: pse-pd: do not tie a shared power domain to its creator's devres

From: Carlo Szelinsky

Date: Fri Nov 20 2026 - 03:33:36 EST


On Fri, 20 Nov 2026 06:41:51 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> The new kernel-doc for pse_alloc_pw_d() says the domain "must not be tied
> to the lifetime of the controller that happened to create it". Does that
> hold for pw_d->supply?

Not at this patch, but 12/14 removes pw_d->supply. This patch does
not make it worse: before it, the whole domain was freed with its
creator.

> Could the kernel-doc here be adjusted, or could the commit note that it
> depends on that later change for the supply handle?

7 and 12 have the same Fixes: tag, so a backport takes both. If
there is a new version, I will add a note to 7.

> This is a pre-existing issue and was not introduced by this patch, but
> does pse_flush_pw_ds() leak the PI's reserved power budget on the shared
> supply?

Yes, but this is older than this series. The cover letter lists it.

> This isn't a bug introduced by this patch, but the commit message says
> the PI regulator ops use pw_d under pcdev->lock. Is the publication side
> in pse_register_pw_ds() covered too?

No. This is older too, and it is the same short window during probe
as the cover letter item "The PI regulators are visible before their
power domain is set".

Carlo