Re: [PATCH v5 14/17] mm/huge_memory: mark folio as accessed more accurately on split
From: KunWu Chan
Date: Fri Nov 20 2026 - 03:36:35 EST
On Thu, Nov 19, 2026 at 5:03 AM Kairui Song via B4 Relay
<devnull+kasong.tencent.com@xxxxxxxxxx> wrote:
>
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> The behavior of updating the folio's access info isn't consistent for
> huge mapping splitting or ordinary unmapping. The page table's young
> flag has to be translated into folio's access info.
>
> Right now it only checks and sets the folio's referenced flag, which isn't
> enough since folio flag updates on access have their own rules. Ordinary
> unmapping (zapping) calls folio_mark_accessed(), and it also checks
> if the VMA has recency to avoid false updates.
>
> So first just use the right helper here to be more consistent. Keep
> accounting the young PTE as a cache access, sticking to the current
> behavior.
>
> Tested-by: Zhao Zhenzhuo <zhaozhengzhuo@xxxxxxxxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
> ---
> mm/huge_memory.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 0d589be136d2..1a415a6704be 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3104,8 +3104,8 @@ static void __split_huge_pud_locked(struct vm_area_struct *vma, pud_t *pud,
>
> if (!folio_test_dirty(folio) && pud_dirty(old_pud))
> folio_mark_dirty(folio);
> - if (!folio_test_referenced(folio) && pud_young(old_pud))
> - folio_set_referenced(folio);
> + if (pud_young(old_pud) && vma_has_recency(vma))
> + folio_mark_accessed(folio);
> folio_remove_rmap_pud(folio, page, vma);
> add_mm_counter(vma->vm_mm, mm_counter_file(folio),
> -HPAGE_PUD_NR);
> @@ -3227,8 +3227,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> folio = page_folio(page);
> if (!folio_test_dirty(folio) && pmd_dirty(old_pmd))
> folio_mark_dirty(folio);
> - if (!folio_test_referenced(folio) && pmd_young(old_pmd))
> - folio_set_referenced(folio);
> + if (pmd_young(old_pmd) && vma_has_recency(vma))
> + folio_mark_accessed(folio);
> folio_remove_rmap_pmd(folio, page, vma);
> add_mm_counter(mm, mm_counter_file(folio), -HPAGE_PMD_NR);
> folio_put(folio);
>
> --
> 2.56.1
>
>
Reviewed-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>
Thanks,
Kunwu