Re: [PATCH v3 0/4] can: kvaser_usb: validate values received from the device

From: Marc Kleine-Budde

Date: Fri Nov 20 2026 - 03:38:27 EST


On 12.11.2026 17:27:54, Joas Antonio dos Santos via B4 Relay wrote:
> Four fixes for values that kvaser_usb takes from the USB device without
> checking them.
>
> Patch 1 rejects hydra commands whose length is shorter than a standard
> command. A length of zero otherwise stalls the command loops, and a
> short extended command makes the handlers read past the command.
>
> Patch 2 rejects devices that report zero max outstanding tx, which
> otherwise leads to a division by zero.
>
> Patch 3 stops the hydra command parsers from reading the length of an
> extended command before it has been received.
>
> Patch 4 checks the error frame data and the payload of extended rx
> commands against the command length.
>
> These issues were found with the help of an LLM-based code review tool
> (Claude); patches 3 and 4 address the points of the Sashiko review of
> v2. I checked the code paths by hand against v7.4-rc3 and reviewed the
> fixes myself. They are build-tested only (W=1, arm64); I do not have
> the hardware to test them at runtime. In particular patch 4 assumes
> that the firmware includes the error frame data and the payload in the
> command length, which follows from how the parsers advance through the
> buffer but which I could not confirm on a device.

Please evaluate the patch by Cen Zhang, fixing a similar issue:

| https://lore.kernel.org/all/20261015015336.816543-33-mkl@xxxxxxxxxxxxxx/

Explain which solution is better and why.

regards,
Marc

> ---
> Changes in v3:
> - New patch 3: do not read the extended command length before bytes 4
> and 5 are received, in kvaser_usb_hydra_wait_cmd() and
> kvaser_usb_hydra_read_bulk_callback() (sashiko review of v2).
> - New patch 4: check err_frame_data and kcan_payload against the command
> length in kvaser_usb_hydra_rx_msg_ext() (sashiko review of v2).
> - Patches 1 and 2: unchanged.
> - Link to v2: https://lore.kernel.org/r/20261111-kvaser-usb-validate-v2-0-193dc10ca19b@xxxxxxxxx
>
> Changes in v2:
> - Patch 1: require at least sizeof(struct kvaser_cmd) instead of the
> 4-byte header, so that the extended command handlers do not read past
> a short command (sashiko review of v1). Subject changed, it was
> "can: kvaser_usb: hydra: reject commands shorter than the header".
> - Patch 2: unchanged.
> - Link to v1: https://lore.kernel.org/r/20261110-kvaser-usb-validate-v1-0-f266b85aa908@xxxxxxxxx
>
> ---
> Joas Antonio dos Santos (4):
> can: kvaser_usb: hydra: reject commands shorter than a standard command
> can: kvaser_usb: reject devices reporting zero max outstanding tx
> can: kvaser_usb: hydra: do not read the command length before it is received
> can: kvaser_usb: hydra: check the payload of extended rx commands
>
> drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 6 ++
> drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 67 +++++++++++++++++++++--
> 2 files changed, 68 insertions(+), 5 deletions(-)
> ---
> base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
> change-id: 20261110-kvaser-usb-validate-33c2e34b63bf
>
> Best regards,
> --
> Joas Antonio dos Santos <joasantonio108@xxxxxxxxx>
>
>
>
>

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature