Re: [PATCH 3/3] perf/core: Don't zero perf_sample_data in do_perf_sw_event()
From: Peter Zijlstra
Date: Fri Nov 20 2026 - 04:12:23 EST
On Thu, Nov 19, 2026 at 01:10:46PM -0800, Usama Arif wrote:
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 57ea7e3c01a025..fa10ad7cfd99af 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -11212,7 +11212,7 @@ static void do_perf_sw_event(enum perf_type_id type, u32 event_id,
> u64 nr, struct pt_regs *regs, u64 addr)
> {
> struct swevent_htable *swhash = this_cpu_ptr(&swevent_htable);
> - struct perf_sample_data data;
> + struct perf_sample_data data __uninitialized;
> struct perf_event *event;
> struct hlist_head *head;
>
I like this one, didn't know about the __uninitialized thing. But I
think we wants to be more consistent with this.
A little git-grep seems to suggest we ought to do the same elsewhere.
Shall I fold the little something below in this patch?
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9123,7 +9123,7 @@ perf_event_read_event(struct perf_event
struct task_struct *task)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct perf_read_event read_event = {
.pid = perf_event_pid(event, task),
.tid = perf_event_tid(event, task),
@@ -9390,7 +9390,7 @@ static void perf_event_task_output(struc
{
struct perf_task_event *task_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct task_struct *task = task_event->task;
int ret;
@@ -9534,7 +9534,7 @@ static void perf_event_comm_output(struc
{
struct perf_comm_event *comm_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
if (!perf_event_comm_match(event))
@@ -9625,7 +9625,7 @@ static void perf_event_namespaces_output
{
struct perf_namespaces_event *namespaces_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
if (!perf_event_namespaces_match(event))
@@ -9748,7 +9748,7 @@ static void perf_event_cgroup_output(str
{
struct perf_cgroup_event *cgroup_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
u16 size = sizeof(cgroup_event->event_id) + cgroup_event->path_size;
@@ -9859,7 +9859,7 @@ static void perf_event_mmap_output(struc
{
struct perf_mmap_event *mmap_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int size = sizeof(mmap_event->event_id) + mmap_event->file_size;
u32 type = PERF_RECORD_MMAP;
u16 misc = PERF_RECORD_MISC_USER;
@@ -10155,7 +10155,7 @@ void perf_event_aux_event(struct perf_ev
unsigned long size, u64 flags)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct perf_aux_event {
struct perf_event_header header;
u64 offset;
@@ -10188,7 +10188,7 @@ void perf_event_aux_event(struct perf_ev
void perf_log_lost_samples(struct perf_event *event, u64 lost)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
struct {
@@ -10240,7 +10240,7 @@ static void perf_event_switch_output(str
{
struct perf_switch_event *se = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
u32 type;
u16 misc;
u16 size;
@@ -10307,7 +10307,7 @@ static void perf_event_switch(struct tas
static void perf_log_throttle(struct perf_event *event, int enable)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
struct {
@@ -10363,7 +10363,7 @@ static void perf_event_ksymbol_output(st
{
struct perf_ksymbol_event *ksymbol_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
u16 size = sizeof(ksymbol_event->event_id) + ksymbol_event->name_len;
@@ -10450,7 +10450,7 @@ static void perf_event_bpf_output(struct
{
struct perf_bpf_event *bpf_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
int ret;
if (!perf_event_bpf_match(event))
@@ -10540,7 +10540,7 @@ static void perf_callchain_deferred_outp
{
struct perf_callchain_deferred_event *deferred_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
u64 nr = deferred_event->trace->nr;
u16 size, id_size, max_payload;
int ret;
@@ -10615,7 +10615,7 @@ static void perf_event_text_poke_output(
{
struct perf_text_poke_event *text_poke_event = data;
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
u16 size = sizeof(text_poke_event->event_id) + text_poke_event->tot + text_poke_event->pad;
u64 padding = 0;
int ret;
@@ -10686,7 +10686,7 @@ EXPORT_SYMBOL_GPL(perf_event_itrace_star
static void perf_log_itrace_start(struct perf_event *event)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct perf_aux_event {
struct perf_event_header header;
u32 pid;
@@ -10721,7 +10721,7 @@ static void perf_log_itrace_start(struct
void perf_report_aux_output_id(struct perf_event *event, u64 hw_id)
{
struct perf_output_handle handle;
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct perf_aux_event {
struct perf_event_header header;
u64 hw_id;
@@ -11603,7 +11603,7 @@ void perf_tp_event(u16 event_type, u64 c
struct pt_regs *regs, struct hlist_head *head, int rctx,
struct task_struct *task)
{
- struct perf_sample_data data;
+ struct perf_sample_data data __uninitialized;
struct perf_event *event;
/*
@@ -11949,7 +11949,7 @@ void perf_event_free_bpf_prog(struct per
#ifdef CONFIG_HAVE_HW_BREAKPOINT
void perf_bp_event(struct perf_event *bp, void *data)
{
- struct perf_sample_data sample;
+ struct perf_sample_data sample __uninitialized;
struct pt_regs *regs = data;
/*
@@ -12403,7 +12403,7 @@ static int perf_event_set_filter(struct
static enum hrtimer_restart perf_swevent_hrtimer(struct hrtimer *hrtimer)
{
enum hrtimer_restart ret = HRTIMER_RESTART;
- struct perf_sample_data data;
+ struct perf_sample_data data __uninitialized;
struct pt_regs *regs;
struct perf_event *event;
u64 period;