[PATCH 1/4] dmaengine: stm32-dma3: clear flags before signaling transfer completion

From: Amelie Delaunay

Date: Fri Nov 20 2026 - 04:18:35 EST


From: Jerome Audu <jerome.audu@xxxxxx>

On a Transfer Complete event, a new transfer can be started from
stm32_dma3_chan_complete(). The new transfer may finish while the end of
stm32_dma3_chan_irq() is still executing, in which case the flag clearing
done at the end of the handler also clears the new transfer's Transfer
Complete flag without the end of that transfer being handled, which may
lead to a timeout.

Clear the flags before handling completion to make sure that if
stm32_dma3_chan_complete() starts an ultra-fast transfer, its TCF flag is
not accidentally cleared. This reordering is also safe for the other
handled interrupt conditions, since csr holds the channel status and is
used to select the handling path.

Fixes: f561ec8b2b33 ("dmaengine: Add STM32 DMA3 support")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Jerome Audu <jerome.audu@xxxxxx>
Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>
---
drivers/dma/stm32/stm32-dma3.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c
index 4fe226541efa..a464e0cefd64 100644
--- a/drivers/dma/stm32/stm32-dma3.c
+++ b/drivers/dma/stm32/stm32-dma3.c
@@ -1008,7 +1008,7 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid)
{
struct stm32_dma3_chan *chan = devid;
struct stm32_dma3_ddata *ddata = to_stm32_dma3_ddata(chan);
- u32 misr, csr, ccr;
+ u32 misr, csr, ccr, cfcr;

spin_lock(&chan->vchan.lock);

@@ -1021,6 +1021,14 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid)
csr = readl_relaxed(ddata->base + STM32_DMA3_CSR(chan->id));
ccr = readl_relaxed(ddata->base + STM32_DMA3_CCR(chan->id)) & CCR_ALLIE;

+ /*
+ * Half Transfer Interrupt may be disabled but Half Transfer Flag can be set,
+ * ensure HTF flag to be cleared, with other flags.
+ */
+ cfcr = csr & (ccr | CCR_HTIE);
+ if (cfcr)
+ writel_relaxed(cfcr, ddata->base + STM32_DMA3_CFCR(chan->id));
+
if (csr & CSR_TCF && ccr & CCR_TCIE) {
if (chan->swdesc->cyclic)
vchan_cyclic_callback(&chan->swdesc->vdesc);
@@ -1050,15 +1058,6 @@ static irqreturn_t stm32_dma3_chan_irq(int irq, void *devid)
stm32_dma3_chan_reset(chan);
}

- /*
- * Half Transfer Interrupt may be disabled but Half Transfer Flag can be set,
- * ensure HTF flag to be cleared, with other flags.
- */
- csr &= (ccr | CCR_HTIE);
-
- if (csr)
- writel_relaxed(csr, ddata->base + STM32_DMA3_CFCR(chan->id));
-
spin_unlock(&chan->vchan.lock);

return IRQ_HANDLED;

--
2.43.0