Re: [PATCH] hwrng: npcm - use pm_runtime_resume_and_get() in npcm_rng_read()
From: Herbert Xu
Date: Fri Nov 20 2026 - 04:51:08 EST
On Wed, Nov 11, 2026 at 03:33:08PM +0800, Gu Bin wrote:
> npcm_rng_read() calls pm_runtime_get_sync() without checking the return
> value and then polls and reads the RNG registers: when resuming the
> device fails (negative return), the loop reads a device that never
> resumed and the failure is lost - the function returns the (zero) byte
> count instead of an error.
>
> Use pm_runtime_resume_and_get() instead and bail out on the error: the
> helper reports the resume failure and drops the usage counter reference
> it took, which a failed pm_runtime_get_sync() leaves behind (the usage
> counter is incremented before the resume attempt, so returning
> directly after a failed get_sync() would leak the reference and the
> device could never autosuspend again). The tail
> pm_runtime_put_sync_autosuspend() must not be used for this bailout:
> the device never resumed, so balancing the counter is all that is
> needed. On success the helper returns 0, which is exactly what the
> read counter expects at that point.
>
> Fixes: c98429297d8b ("hwrng: npcm - add NPCM RNG driver")
> Signed-off-by: Gu Bin <gubin@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/char/hw_random/npcm-rng.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt