Re: [PATCH] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()
From: Andi Shyti
Date: Fri Nov 20 2026 - 04:59:19 EST
Hi Haoxing,
On Wed, Nov 18, 2026 at 11:32:05PM +0800, Haoxiang Li wrote:
> i915_vma_pin_ww() allocates bind work before retrieving the object's
> moving fence. If the lookup fails, it jumps to err_rpm, bypassing the
> fence commit at err_fence and leaking the work allocation.
>
> Jump to err_fence instead so the fence callbacks can release the work.
BTW, this commit description, along with the title, is too
LLM-ish. Can you please write a simpler and more descriptive
commit message?
Please do not blindly rely on your LLM for this. Write it
yourself and use the LLM only to fix the grammar.
It would also be interesting to explain how this oversight
(because that's what it is) happened in the first place.
I'll wait for v2. You can add my R-b as well.
Andi