Re: [RFC PATCH 2/2] fcntl: recheck signal permissions before falling back to SIGIO
From: Christian Brauner
Date: Fri Nov 20 2026 - 05:48:43 EST
On Sat, Nov 07, 2026 at 11:49:28PM +0800, Shi Lecun wrote:
> F_SETSIG allows a file owner to request a signal other than SIGIO.
> send_sigio_to_task() checks permission for the configured signal, but
> if queuing fails, it falls back to SIGIO without checking permission
> for the fallback. Permission for the configured signal does not imply
> permission for SIGIO.
Yes, we should check the signal we actually send. Without your aa patch
selinux, smack and landlock treat a realtime signal and SIGIO the same.
So only a bpf lsm program attached to file_send_sigiotask would notice.
So please move this to the front of the series.
Acked-by: Christian Brauner <brauner@xxxxxxxxxx>