Re: [PATCH v8 2/4] usb: gadget: f_tcm: zero the CBW buffer the status path sends

From: Greg KH

Date: Fri Nov 20 2026 - 05:55:37 EST


On Wed, Nov 18, 2026 at 09:40:03PM +0900, Yehyeong Lee wrote:
> bot_prepare_reqs() allocates fu->cmd[0].buf with kmalloc(), one endpoint
> maxpacket in size, and the only thing ever written into it is the 31-byte
> CBW the host sends. The rest is never initialised.
>
> When a command is rejected before its data stage, bot_send_bad_status()
> points the status request at that same buffer and queues it to the IN
> endpoint for a read, and bot_err_compl() re-queues it until the length the
> host declared in the CBW is satisfied. So the host gets the buffer's
> contents back, a maxpacket at a time, for as long a transfer as it asked
> for, and whatever lies past the CBW it never wrote.
>
> Allocate it with kzalloc().
>
> On a dummy_hcd gadget with a 512-byte bulk maxpacket, a rejected IN
> command declaring 4096 bytes returns 4096 bytes to the host, of which 72
> are non-zero and begin with the previous CBW's "USBC" signature. The
> part no CBW ever writes read back as zero there, both before and after
> this patch, so what that buffer held beforehand was not observed; what
> the test does show is that the host is handed a buffer it only ever
> wrote 31 bytes of.
>
> Hui Peng's multi-driver fix of 2026-09-19 zeroed this buffer too; the
> reviewer asked for it to be split per driver and it was not applied.

Why is this line in the changelog? It shouldn't be.