Re: [RFC PATCH 02/28] media: mali-vpu: add Mali VPU platform driver

From: Uwe Kleine-König

Date: Fri Nov 20 2026 - 06:48:19 EST


On Thu, Nov 19, 2026 at 03:37:32PM +0000, Charvi Mehta wrote:
> +#include <linux/bitfield.h>
> +#include <linux/clk.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/errno.h>
> +#include <linux/io.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>.

> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>

<linux/platform_device.h> already provides of_device_id, so
<linux/mod_devicetable.h> can just be dropped.

> [...]
> +static const struct of_device_id mali_vpu_dt_match[] = {
> + {
> + .compatible = "arm,mali-v76",
> + .data = &mali_vpu_v76_variant,
> + },
> + {},

s/{},/{ }/

> +};
> +MODULE_DEVICE_TABLE(of, mali_vpu_dt_match);

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature