Re: [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111
From: Matti Vaittinen
Date: Fri Nov 20 2026 - 07:01:51 EST
On 18/11/2026 19:37, Conor Dooley wrote:
On Wed, Nov 18, 2026 at 04:19:11PM +0200, Matti Vaittinen wrote:
From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices,
where pins can be configured to be either used as GPIO or ADC inputs.
ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ
sources.
The main difference is amount of channels/GPIOs. The BD79112 has 32 pins
for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet
promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas
the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI
clock.
Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
---
Note, I had to change the 'root-level' additionalProperties: false to
unevaluatedProperties: false in order to allow the properties in the new
allOf:
- if:
...
section. It seems to me this is what a few other bindings in IIO do, but
I suppose it makes this "less strict". Well, since I am terrible with
writing bindings, I'd better point this out and ask if it's ok, or if
there are better way(s) to handle this?
I don't think you should have to do that though, since the children are
described in the same file.
If you instead retained the pattern properties section, and lowered the
restriction to channel@<any number> with reg with the max of 31 and in
the conditional section constrained reg to a max of 16 does it work
without the unevaluatedProperties change? We typically want properties
defined at the top level and constrained in conditional sections anyway.
Gah. Either I don't know how to do this properly (which is likely), or there is a slight caveat. When I tried to do what you suggest, the binding allowed channel@X, where the <X> was is out of the range. Sure thing this was caught by 'reg' being out of the range, but it still allowed odd combination of
channel@X, reg = <Y>, if Y was in accepted range.
I suppose the 'X' and 'Y' in previous example are expected to always be the same, but I would still like to catch this type of an error.
I am about to spin v2 where I use the BD79112 limits (channels 0 to 31 allowed) in the pattern properties, and then do:
"^channel@(1[6-9]|2[0-9]|3[01])$": false
to exclude 16 - 31 from the BD79111.
I am not super happy with it, but it seems to work and is still decently understandable even for someone yaml -illiterate like myself. :/ (At least for as long as we only have ICs which don't increase the amount of default channels. That might cause the exclusion regexp on other ICs to become ridiculously long or hard to read. Well, I don't have such ICs on sight for now.)
Well, let's see what people think of it :)
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~