Re: [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal

From: Greg Kroah-Hartman

Date: Fri Nov 20 2026 - 07:11:00 EST


On Wed, Nov 18, 2026 at 10:10:53PM +0800, Guangshuo Li wrote:
> usb_del_gadget_udc() can drop the last gadget device reference and call
> fsl_udc_release(), which frees udc_controller. The remaining remove path
> then dereferences it to release its requests, endpoints and DMA pool.
>
> Hold a gadget device reference until this cleanup has finished.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
> index 878d70b55530..9d9d2164c5bf 100644
> --- a/drivers/usb/gadget/udc/fsl_udc_core.c
> +++ b/drivers/usb/gadget/udc/fsl_udc_core.c
> @@ -2537,6 +2537,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
> DECLARE_COMPLETION_ONSTACK(done);
>
> udc_controller->done = &done;
> + get_device(&udc_controller->gadget.dev);

This feels wrong, why are you needing a fake reference here?

> usb_del_gadget_udc(&udc_controller->gadget);

This is where it should all go away. If not, then reorder the code
properly.