Re: [PATCH 1/3] arm64: dts: renesas: r9a08g046: Add SDHI nodes for RZ/G3L SoC and SDHI1 pincontrol on SMARC EVK

From: Geert Uytterhoeven

Date: Fri Nov 20 2026 - 07:52:38 EST


Hi Biju,

On Thu, 12 Nov 2026 at 19:48, Biju Das <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Add device tree nodes for the three SDHI controllers (SDHI{0,1,2})
> on the RZ/G3L SoC (r9a08g046) and enable SDHI1 on the RZ/G3L SMARC
> EVK platform with pincontrol and GPIO-based voltage switching
> regulator support.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> @@ -1062,9 +1062,80 @@ dmac: dma-controller@11820000 {
> dma-channels = <16>;
> };
>
> + sdhi0: mmc@11c00000 {
> + compatible = "renesas,sdhi-r9a08g046";
> + reg = <0x0 0x11c00000 0 0x10000>;
> + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD R9A08G046_SDHI0_IMCLK>,
> + <&cpg CPG_MOD R9A08G046_SDHI0_CLK_HS>,
> + <&cpg CPG_MOD R9A08G046_SDHI0_IMCLK2>,
> + <&cpg CPG_MOD R9A08G046_SDHI0_IACLKM>,
> + <&cpg CPG_MOD R9A08G046_SDHI0_IACLKS>;
> + clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> + max-frequency = <150000000>;

Given the bus clock can only run at 200, 100, 50, or 6.25 MHz,
150 Mhz looks strange to me.

> + resets = <&cpg R9A08G046_SDHI0_IXRST>,
> + <&cpg R9A08G046_SDHI0_IXRSTAXIM>,
> + <&cpg R9A08G046_SDHI0_IXRSTAXIS>;
> + reset-names = "rst", "axim", "axis";
> + power-domains = <&cpg>;
> + status = "disabled";
> + };
> +
> sdhi1: mmc@11c10000 {
> + compatible = "renesas,sdhi-r9a08g046";
> reg = <0x0 0x11c10000 0 0x10000>;
> - /* placeholder */
> + interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD R9A08G046_SDHI1_IMCLK>,
> + <&cpg CPG_MOD R9A08G046_SDHI1_CLK_HS>,
> + <&cpg CPG_MOD R9A08G046_SDHI1_IMCLK2>,
> + <&cpg CPG_MOD R9A08G046_SDHI1_IACLKM>,
> + <&cpg CPG_MOD R9A08G046_SDHI1_IACLKS>;
> + clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> + max-frequency = <150000000>;

Likewise. This instance does not support HS400, but HS200 and HS400
use the same bus clock speed, right?

> + resets = <&cpg R9A08G046_SDHI1_IXRST>,
> + <&cpg R9A08G046_SDHI1_IXRSTAXIM>,
> + <&cpg R9A08G046_SDHI1_IXRSTAXIS>;
> + reset-names = "rst", "axim", "axis";
> + power-domains = <&cpg>;
> + status = "disabled";
> +
> + sdhi1_vqmmc: vqmmc-regulator {
> + regulator-name = "SDHI1-VQMMC";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-ramp-delay = <1200>;
> + status = "disabled";
> + };
> + };
> +
> + sdhi2: mmc@11c20000 {
> + compatible = "renesas,sdhi-r9a08g046";
> + reg = <0x0 0x11c20000 0 0x10000>;
> + interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD R9A08G046_SDHI2_IMCLK>,
> + <&cpg CPG_MOD R9A08G046_SDHI2_CLK_HS>,
> + <&cpg CPG_MOD R9A08G046_SDHI2_IMCLK2>,
> + <&cpg CPG_MOD R9A08G046_SDHI2_IACLKM>,
> + <&cpg CPG_MOD R9A08G046_SDHI2_IACLKS>;
> + clock-names = "core", "clkh", "cd", "aclkm", "aclks";
> + max-frequency = <150000000>;

This instance maxes out at SDR104, so max-frequency should be lower?

> + resets = <&cpg R9A08G046_SDHI2_IXRST>,
> + <&cpg R9A08G046_SDHI2_IXRSTAXIM>,
> + <&cpg R9A08G046_SDHI2_IXRSTAXIS>;
> + reset-names = "rst", "axim", "axis";
> + power-domains = <&cpg>;
> + status = "disabled";
> +
> + sdhi2_vqmmc: vqmmc-regulator {
> + regulator-name = "SDHI2-VQMMC";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-ramp-delay = <1200>;
> + status = "disabled";
> + };
> };

The rest LGTM.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds